[READY] Use setlocal for temporary completeopt adjustment #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since vim 9.1.0469, completeopt is a global-local option. When adding `noselect`, we need to treat `completeopt` as local and use `setlocal`. This works for 9.1.0016 as well and allows users to freely mess with buffer-local `completeopt` without messing up YCM completions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4264 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 37 37
Lines 4758 4758
=======================================
Hits 4273 4273
Misses 485 485 |
| @@ -1357,7 +1357,7 @@ function! s:Complete() | |||
| endif | |||
| if len( s:completion.completions ) | |||
| let old_completeopt = &completeopt | |||
| set completeopt+=noselect | |||
| setlocal completeopt+=noselect | |||
| call complete( s:completion.completion_start_column, | |||
| \ s:completion.completions ) | |||
| let &completeopt = old_completeopt | |||
There was a problem hiding this comment.
Does this set the buffer local or global value? If it was previously globally set does this make it buffer local? I'm not sure that's desirable
There was a problem hiding this comment.
This does set the buffer-local value.If it was previously globally set, this does make it buffer-local.
I've manually tested this scenario:
- Do some completion thing, so that we mess with buffer-local
completeopt. - Manually mess with the global value. At the point, the buffer-local
completeoptis destroyed, because global config changed. - Do more completion.
That worked as expected and the end result is that both global and buffer-local completeopt have the same value.
Can you think of more potentially broken scenarios to test?
puremourning
approved these changes
Sep 14, 2024
|
|
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
Since vim 9.1.0469, completeopt is a global-local option.
When adding
noselect, we need to treatcompleteoptas local and usesetlocal.This works for 9.1.0016 as well and allows users to freely mess with buffer-local
completeoptwithout messing up YCM completions.
Fixes #4261
This change is