Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Make vimsupport.BuildRange construct a half-open range #4266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Sep 17, 2024

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

The rest of YCM is already dealing with half-open ranges and so does LSP.
In fact, ycmd assumes this is a half-open range, so YCM had a bug.

Though I have to look at what non-LSP completers are doing.


This change is Reviewable

The rest of YCM is already dealing with half-open ranges and so does
LSP.
In fact, ycmd assumes this is a half-open range, so YCM had a bug.
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (63ab13e) to head (b31f3db).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4266      +/-   ##
==========================================
- Coverage   89.95%   89.80%   -0.15%     
==========================================
  Files          37       37              
  Lines        4758     4758              
==========================================
- Hits         4280     4273       -7     
- Misses        478      485       +7     

@puremourning
Copy link
Member

puremourning commented Sep 18, 2024

:lgtm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants