Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ycmd #4280

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update ycmd #4280

merged 1 commit into from
Dec 12, 2024

Conversation

puremourning
Copy link
Member

@puremourning puremourning commented Dec 12, 2024 •
edited by Valloric
Loading

Fixes usage on Python 3.13.

Submodule third_party/ycmd 8b61f198..d8c3b699:

Upgrade jedi to support python 3.13
Merge pull request #1764 from bstaletic/regex-optional
Upgrade to unicode 16
Merge pull request #1763 from bstaletic/llvm19

This change is Reviewable

@puremourning
Update ycmd
19fa3c8 
Fixes usage on Python 3.13.

Submodule third_party/ycmd 8b61f198..d8c3b699:
  > Upgrade jedi to support python 3.13
  > Merge pull request #1764 from bstaletic/regex-optional
  > Upgrade to unicode 16
  > Merge pull request #1763 from bstaletic/llvm19
puremourning
puremourning commented Dec 12, 2024
View reviewed changes
Copy link
Member Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @puremourning)

bstaletic
bstaletic approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @puremourning)

@puremourning puremourning added the Ship It! Manual override to merge a PR by maintainer label Dec 12, 2024
puremourning
puremourning commented Dec 12, 2024
View reviewed changes
Copy link
Member Author

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 2 of 2 LGTMs obtained (waiting on @puremourning)

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (35d1882) to head (19fa3c8).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4280      +/-   ##
==========================================
- Coverage   89.95%   89.80%   -0.15%     
==========================================
  Files          37       37              
  Lines        4758     4758              
==========================================
- Hits         4280     4273       -7     
- Misses        478      485       +7

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

Thanks for sending a PR!

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

Thanks for sending a PR!

@mergify mergify bot merged commit f56c0cb into master Dec 12, 2024
12 of 14 checks passed
@puremourning puremourning deleted the update-ycmd branch December 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstaletic bstaletic bstaletic approved these changes

Assignees
No one assigned
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puremourning @bstaletic