Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "-source" option for gocode autocompletion #1125

Closed
wants to merge 2 commits into from
Closed

add "-source" option for gocode autocompletion #1125

wants to merge 2 commits into from

Conversation

kyoh86
Copy link

@kyoh86 kyoh86 commented Oct 17, 2018

Now, ycmd cannot complete golang external packages.
ycmd must enable source importer with -source flag.


This change is Reviewable

@kyoh86
Copy link
Author

kyoh86 commented Oct 17, 2018

for your reference: mdempsky/gocode#32 (comment)

@bstaletic
Copy link
Collaborator

What worries me about this is the performance impact it imposes. However, I have never used go, so I would like to hear from go users if this is something we really want to enable by default.

@bstaletic
Copy link
Collaborator

Looking at the tests, something is clearly broken here. 3 out of 6 are broken because the expected call in the tests doesn't have -source, but the other three say that gocode panicked, even the basic completion test failed because there are syntax errors in the file.

@kyoh86
Copy link
Author

kyoh86 commented Nov 2, 2018

oh I see, sorry. I'll fix it later.

@kyoh86
Copy link
Author

kyoh86 commented Nov 9, 2018

gocode panicked

Sorry, I cannot reproduce the error on local...

@Valloric
Copy link
Member

@kyoh86

Sorry, I cannot reproduce the error on local...

We rely on CI bots to ensure all tests pass. If a PR cannot pass tests on our CI infrastructure, it cannot be merged.

@micbou
Copy link
Collaborator

micbou commented Mar 6, 2019

PR seems abandoned. Closing.

@micbou micbou closed this Mar 6, 2019
@kyoh86 kyoh86 deleted the gocode-with-source branch March 10, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants