-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Use a http wrapper for jedi #160
Closed
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5d752d5
Basic completion working with JediHTTP
vheon 94ebb66
WaitUntilJediHTTPServerReady in tests
vheon 8d2d348
Implement Shutdown
vheon a6ff95c
Implement StopServer subcommand
vheon 400f5cf
Stop JediHTTP when tests are done
vheon 44efb6d
Handle errors from JediHTTP
vheon 27fd5cb
Update JediHTTP and error handling.
vheon 76d3a20
Implement GoTo* subcommands
vheon 78a2160
Update JediHTTP
vheon 6782dd8
Fix _ConvertRequestForJediHTTP
vheon 943a46d
Remove jedi Subproject
vheon f7a24a2
Conver request parameters when needed in _GetResponse
vheon 41e3a91
Start JediHTTP server before asking for completions in tests
vheon 8fe5aee
Send less data with FileReadyToParse event in test
vheon cdee53c
Refactor ActivateJediHTTPServer
vheon 48976be
Implement RestartServer for JediHTTP completer
vheon d9a7972
Update tests for JediHTTP completer subcommand
vheon 51d132b
Fix whitespaces
vheon 755841e
/ready should check also on JediHTTP
vheon 231cf5a
Restored removed logging statement
vheon a069ac2
Move code to simplify diff
vheon 4c9b80c
Remove blank line
vheon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule jedi
deleted from
665579
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to use
os.path.pardir
instead of hardcoding'..'
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from the doc I read that
pardir
is'..'
for Windows and POSIX which is all the necessary for ycmd. Plus we use this pattern over all ycmd codebase. What would be the advantage of usingpardir
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I was mostly thinking of compatibility, but since they use the same string anyway it's probably not very important. I guess the advantage would be if some platform used something other than
..
it will just work (given that Python supports that platform of course).