Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Switch C# completer to LSP #1752

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[RFC] Switch C# completer to LSP #1752

wants to merge 7 commits into from

Commits on Aug 23, 2024

  1. Switch C# completer to LSP 

    Currently missing pieces:

- GetDoc just does not exist in LSP mode.
- CodeActions are ill-formed and hit a million asserts in ycmd.
- Currently only works with user_option roslyn_binary_path.
- GetProjectRootFiles returns an empty list, so users need to cd to
  their desired project root.
    @bstaletic
    bstaletic committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c5b87a7 View commit details
    Browse the repository at this point in the history

  2. Update to the latest omnisharp-roslyn version 

    - Update to 1.39.12
- Make `mono` optional
    @bstaletic
    bstaletic committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e4286f0 View commit details
    Browse the repository at this point in the history

  3. Attempt to fix C# tests

    @bstaletic
    bstaletic committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2f18c12 View commit details
    Browse the repository at this point in the history

  4. Add support for GetDoc in C# 

    LSP OmniSharp-Roslyn uses a different request than we previously have for
this purposes.

This results in some questionable formatting, but there's no way we can
fix that without breaking other stuff.
    @bstaletic
    bstaletic committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9ac9743 View commit details
    Browse the repository at this point in the history

  5. Add tests for omnisharp server management

    @bstaletic
    bstaletic committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c7c0692 View commit details
    Browse the repository at this point in the history

  6. Fix flake8 errors

    @bstaletic
    bstaletic committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    606c481 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Install dotnet 8 in CI

    @puremourning
    puremourning committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4e5f77b View commit details
    Browse the repository at this point in the history