Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add FreeBSD support for detetecting libclang #804

Merged
merged 1 commit into from
Jul 28, 2017
Merged

add FreeBSD support for detetecting libclang #804

merged 1 commit into from
Jul 28, 2017

Conversation

monwarez
Copy link
Contributor

@monwarez monwarez commented Jul 27, 2017 •
edited by Valloric
Loading

This PR simply add usual path to llvm lib on FreeBSD system.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jul 27, 2017 •
edited
Loading

Codecov Report

Merging #804 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files          79       79           
  Lines        5317     5317           
  Branches      170      170           
=======================================
  Hits         5038     5038           
  Misses        232      232           
  Partials       47       47

@vheon
Copy link
Contributor

vheon commented Jul 27, 2017

:lgtm:

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

@bstaletic
Copy link
Collaborator

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

cpp/ycm/CMakeLists.txt, line 283 at r1 (raw file):

    file( GLOB SYS_LLVM_PATHS "/usr/lib/llvm*/lib" )
    # On FreeBSD , llvm install into /usr/local/llvm-xy
    file ( GLOB FREEBSD_LLVM_PATHS "/usr/local/llvm*/lib")

What happens when a user has more than one llm available? Is there a possibility to detect a version that is too old if we do it this way?

Comments from Reviewable

@vheon
Copy link
Contributor

vheon commented Jul 27, 2017

Review status: all files reviewed at latest revision, 1 unresolved discussion.

cpp/ycm/CMakeLists.txt, line 283 at r1 (raw file):

Previously, bstaletic (Boris Staletic) wrote…

What happens when a user has more than one llm available? Is there a possibility to detect a version that is too old if we do it this way?

Well the same is valid for the one 2 lines above, isn't it?

Comments from Reviewable

@bstaletic
Copy link
Collaborator

:lgtm:

@zzbot r=vheon

Review status: all files reviewed at latest revision, 1 unresolved discussion.

cpp/ycm/CMakeLists.txt, line 283 at r1 (raw file):

Previously, vheon (Andrea Cedraro) wrote…

Well the same is valid for the one 2 lines above, isn't it?

It is and we have not had any complaints about that, so I guess ts is fine.

Comments from Reviewable

@zzbot
Copy link
Contributor

zzbot commented Jul 28, 2017

📌 Commit 211a73f has been approved by vheon

@zzbot
Copy link
Contributor

zzbot commented Jul 28, 2017

⌛ Testing commit 211a73f with merge 480b1c7...

zzbot added a commit that referenced this pull request Jul 28, 2017
@zzbot
Auto merge of #804 - monwarez:freebsd-support, r=vheon
480b1c7 
add FreeBSD support for detetecting libclang

This PR simply add usual path to llvm lib on FreeBSD system.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/804)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented Jul 28, 2017

☀️ Test successful - status-travis
Approved by: vheon
Pushing 480b1c7 to master...

@zzbot zzbot merged commit 211a73f into ycm-core:master Jul 28, 2017
@micbou micbou mentioned this pull request Sep 10, 2017
Merged
zzbot added a commit to ycm-core/YouCompleteMe that referenced this pull request Sep 10, 2017
@zzbot
Auto merge of #2768 - micbou:update-ycmd, r=puremourning
fd84aba 
[READY] Update ycmd

This new version of ycmd includes the following changes:

 - PR ycm-core/ycmd#795: add option to make relative paths in flags from extra conf absolute;
 - PR ycm-core/ycmd#802: fix compilation on Haiku;
 - PR ycm-core/ycmd#804: add libclang detection on FreeBSD;
 - PR ycm-core/ycmd#808: write python used during build before installing completers;
 - PR ycm-core/ycmd#810: support unknown languages from tags;
 - PR ycm-core/ycmd#811: update Universal Ctags languages list;
 - PR ycm-core/ycmd#814: resolve symlinks in extra conf glob patterns;
 - PR ycm-core/ycmd#815: update JediHTTP;
 - PR ycm-core/ycmd#816: update Boost to 1.65.0;
 - PR ycm-core/ycmd#819: filter and sort candidates when query is empty;
 - PR ycm-core/ycmd#820: improve LLVM root path search for prebuilt binaries;
 - PR ycm-core/ycmd#822: inline critical utility functions;
 - PR ycm-core/ycmd#824: do not sort header paths in filename completer;
 - PR ycm-core/ycmd#825: implement partial sorting;
 - PR ycm-core/ycmd#830: add max_num_candidates option;
 - PR ycm-core/ycmd#831: fix multiline comments and strings issues;
 - PR ycm-core/ycmd#832: update Clang to 5.0.0.

The `g:ycm_max_num_candidates` and `g:ycm_max_num_identifier_candidates` options are added to the documentation.

The link to ycmd extra conf is updated.

Fixes #2562.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2768)
<!-- Reviewable:end -->
zzbot added a commit to ycm-core/YouCompleteMe that referenced this pull request Sep 10, 2017
@zzbot
Auto merge of #2768 - micbou:update-ycmd, r=micbou
9ca755a 
[READY] Update ycmd

This new version of ycmd includes the following changes:

 - PR ycm-core/ycmd#795: add option to make relative paths in flags from extra conf absolute;
 - PR ycm-core/ycmd#802: fix compilation on Haiku;
 - PR ycm-core/ycmd#804: add libclang detection on FreeBSD;
 - PR ycm-core/ycmd#808: write python used during build before installing completers;
 - PR ycm-core/ycmd#810: support unknown languages from tags;
 - PR ycm-core/ycmd#811: update Universal Ctags languages list;
 - PR ycm-core/ycmd#814: resolve symlinks in extra conf glob patterns;
 - PR ycm-core/ycmd#815: update JediHTTP;
 - PR ycm-core/ycmd#816: update Boost to 1.65.0;
 - PR ycm-core/ycmd#819: filter and sort candidates when query is empty;
 - PR ycm-core/ycmd#820: improve LLVM root path search for prebuilt binaries;
 - PR ycm-core/ycmd#822: inline critical utility functions;
 - PR ycm-core/ycmd#824: do not sort header paths in filename completer;
 - PR ycm-core/ycmd#825: implement partial sorting;
 - PR ycm-core/ycmd#830: add max_num_candidates option;
 - PR ycm-core/ycmd#831: fix multiline comments and strings issues;
 - PR ycm-core/ycmd#832: update Clang to 5.0.0.

The `g:ycm_max_num_candidates` and `g:ycm_max_num_identifier_candidates` options are added to the documentation.

The link to ycmd extra conf is updated.

Fixes #2562.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2768)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@monwarez @codecov-io @vheon @bstaletic @zzbot