Do not try to symlink libclang on Windows

[gokhanettin]

create_symlink is UNIX specific1, and it breaks the build
on Windows.

---

This change is 

[bstaletic]

What's the error this PR is trying to fix? We have build bots constantly building ycmd on Windows and it didn't break once.

[puremourning]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

---

cpp/ycm/CMakeLists.txt, line 412 at r1 (raw file):

    )

    if( NOT APPLE AND NOT WIN32 )

This line is in an else vs if (MSVC). What compiler are you using ?

---

Comments from Reviewable

[gokhanettin]

cpp/ycm/CMakeLists.txt, line 412 at r1 (raw file):

Previously, puremourning (Ben Jackson) wrote…

This line is in an else vs if (MSVC). What compiler are you using ?

After some more modifications I manged to build with MINGW. I have not tried with MSVC. The error was a failure to create the symlink. I have just noticedif (MSVC). It explains why the build bot does not fail, but it would I believe with any other compiler on Windows. I am not sure about cygwin though. May be if (MSVC) should be if(WIN32) or NOT WIN32 should be NOT MINGW in my PR.

---

Comments from Reviewable

[gokhanettin]

I am building with python installer.py --clang-completer --system-libclang using MINGW64.
This PR prevents the code calling cmake.exe -E create_symlink when compiler is not MSVC on Windows.
Here is the error message:

C:\msys64\mingw64\bin\cmake.exe -E create_symlink libclang.dll.a C:/msys64/home/gokhanettin/.config/nvim/plugged/YouCompleteMe/third_party/ycmd/libclang.dll.a""
failed to create symbolic link 'C:/msys64/home/gokhanettin/.config/nvim/plugged/YouCompleteMe/third_party/ycmd/libclang.dll.a': No error
ninja: build stopped: subcommand failed.
Searching Python 2.7 libraries...
Found Python library: C:/msys64/mingw64/lib/python2.7/config/libpython2.7.dll.a
Found Python headers folder: C:/msys64/mingw64/include/python2.7
ERROR: the build failed.

---

Comments from Reviewable

[codecov-io]

Codecov Report

Merging #914 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #914   +/-   ##
======================================
  Coverage    96.2%   96.2%           
======================================
  Files          83      83           
  Lines        6500    6500           
======================================
  Hits         6253    6253           
  Misses        247     247

[micbou]

The symlink is only needed on Linux so it makes sense to exclude Windows (which is going to be MinGW or MSYS in that scenario).

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[bstaletic]

Let's merge this. @zzbot r=micbou

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[zzbot]

📌 Commit 692cfdb has been approved by micbou

[zzbot]

⌛ Testing commit 692cfdb with merge a54135f...

[zzbot]

☀️ Test successful - status-appveyor, status-travis
Approved by: micbou
Pushing a54135f to master...