Remove throw StepNotFoundException

ycs77 · Jun 1, 2024 · 29bb003 · 29bb003
1 parent de463e4
commit 29bb003
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 74 deletions.
diff --git a/composer.json b/composer.json
@@ -20,7 +20,6 @@
     "homepage": "https://github.com/ycs77/laravel-wizard",
     "require": {
         "php": ">=8.1",
-        "facade/ignition-contracts": "^1.0",
         "laravel/framework": ">=9.0"
     },
     "require-dev": {

diff --git a/src/Exceptions/InternalException.php b/src/Exceptions/InternalException.php
diff --git a/src/Exceptions/StepNotFoundException.php b/src/Exceptions/StepNotFoundException.php
diff --git a/src/Wizardable.php b/src/Wizardable.php
@@ -4,7 +4,6 @@
 
 use Closure;
 use Illuminate\Http\Request;
-use Ycs77\LaravelWizard\Exceptions\StepNotFoundException;
 
 trait Wizardable
 {
@@ -316,8 +315,6 @@ protected function getLastProcessedStepIndex(string $stepSlug = null)
      * @param  \Illuminate\Http\Request  $request
      * @param  string|null  $slug
      * @return \Ycs77\LaravelWizard\Step
-     *
-     * @throws \Ycs77\LaravelWizard\Exceptions\StepNotFoundException
      */
     protected function getWizardStep(Request $request, string $slug = null)
     {
@@ -330,7 +327,7 @@ protected function getWizardStep(Request $request, string $slug = null)
         }
 
         if (is_null($step)) {
-            throw new StepNotFoundException($slug, $this->wizard, static::class);
+            abort(404);
         }
 
         $this->wizard()->stepRepo()->setCurrentIndex($step->index());

diff --git a/tests/Feature/HttpTest.php b/tests/Feature/HttpTest.php
@@ -178,21 +178,12 @@ public function testRunAllWizardStepsSaveOnLastStepAndCanBeCachedUploadedFile()
         ]);
     }
 
-    public function testThrowStepNotFoundException()
+    public function testStepNotFound()
     {
-        $this->app['config']->set('app.debug', false);
-
         $response = $this->get('/wizard/test/step-not-found');
         $response->assertStatus(404);
     }
 
-    public function testThrowStepNotFoundExceptionFromDebugMode()
-    {
-        $response = $this->get('/wizard/test/step-not-found');
-        $response->assertStatus(500);
-        $response->assertSee('Step [step-not-found] is not found to Test wizard.');
-    }
-
     public function testWizardStepNotEquialToLastProcessedStep()
     {
         $this->session([