Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extrem value cast as int #225

Closed
bensdm opened this issue Jul 26, 2019 · 1 comment
Closed

extrem value cast as int #225

bensdm opened this issue Jul 26, 2019 · 1 comment
Labels
bug 🐛 Something isn't working

Comments

@bensdm
Copy link

bensdm commented Jul 26, 2019

In the extrem value analysis, it seems that they are casted as int, the result is a bit confusing:

image

while the sorted serie is:

image

@bensdm bensdm added the bug 🐛 Something isn't working label Jul 26, 2019
@sbrugman
Copy link
Collaborator

sbrugman commented Jul 26, 2019

The values are actually not cast to int. The following format is used:

General format.
For a given precision p >= 1, this rounds the number to p significant digits and then formats the result in either fixed-point format or in scientific notation, depending on its magnitude.The precise rules are as follows: suppose that the result formatted with presentation type 'e' and precision p-1 would have exponent exp. Then if -4 <= exp < p, the number is formatted with presentation type 'f' and precision p-1-exp. Otherwise, the number is formatted with presentation type 'e' and precision p-1. In both cases insignificant trailing zeros are removed from the significand, and the decimal point is also removed if there are no remaining digits following it. Positive and negative infinity, positive and negative zero, and nans, are formatted as inf, -inf, 0, -0 and nan respectively, regardless of the precision. A precision of 0 is treated as equivalent to a precision of 1. The default precision is 6.

Source

I suspect it is not possible in Python to know the precision of the float at computation time. The best we can do with the current implementation is allow the user to increase the precision.

Next relase will increase the precision (e.g. 10-15):
Knipsel

sbrugman added a commit that referenced this issue Jan 21, 2020
- Feature as requested in #224
- Many thanks @marco-cardoso for your initial implementation #225
sbrugman added a commit that referenced this issue Feb 2, 2020
* Progress bar implementation

- Feature as requested in #224
- Test for #282
- Many thanks @marco-cardoso for your initial implementation #225
- Display no progress bar for disabled modules (e.g. individual correlations).
- Update requirements, notebooks, docs, examples, linting

* Decouple notebooks and notebook tests. One test hangs on issue in nbval:
computationalmodelling/nbval#136

* Disable missing plots in minimal mode

* Create additional demo with Chicago employees data

* Compartmentalize column sorting in describe module
chanedwin pushed a commit to chanedwin/pandas-profiling that referenced this issue Oct 11, 2020
* Progress bar implementation

- Feature as requested in ydataai#224
- Test for ydataai#282
- Many thanks @marco-cardoso for your initial implementation ydataai#225
- Display no progress bar for disabled modules (e.g. individual correlations).
- Update requirements, notebooks, docs, examples, linting

* Decouple notebooks and notebook tests. One test hangs on issue in nbval:
computationalmodelling/nbval#136

* Disable missing plots in minimal mode

* Create additional demo with Chicago employees data

* Compartmentalize column sorting in describe module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants