-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code refactoring #65
Comments
Sounds like a good idea. It has grown a bit out of the reasonable module length, for sure. If you submit I pull request I will review and check if all works as supposed to. The automated |
Great! I will work on it carefully and let you know. |
* ydataai#68: Backport the fix * ydataai#65: Describe module refactored
I close this issue since the main work has been done. I will open other PR in order to perform other refactoring tasks. |
* ydataai#68: Backport the fix * ydataai#65: Describe module refactored
ydataai#65 Refactoring first step
Hello,
I would like to perform a code refactoring in order to split the big
base.py
module in several modules with separated concerns:plot
: Dedicated to plot features (histograms at this time)describe
: Dedicated to compute the variables descriptionreport
: Dedicated to generate the reportbase
: Containing only remaining common featuresAdditional modules will be ket as is.
formatters
: Containing formatting utilitiestemplates
: Jinja templating helpers and definitionIt's just a first step, then I would like to split the big report generation, but this is another story ;-)
I would like your approval before starting it, since it will change a lot of things.
Many thanks for your answer.
Best,
Romain
The text was updated successfully, but these errors were encountered: