Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch create_expectation_suite with add #1540

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: switch create_expectation_suite with add #1540

merged 1 commit into from
Feb 13, 2024

Conversation

nadavshatz
Copy link
Contributor

based on #1504 switch create_expectation_suite with add_expectation_suite.

This aligns with the changes in great-expectations/great_expectations#7117

@nadavshatz nadavshatz changed the title closes #1504 - switch create_expectation_suite with add fix: #1504 - switch create_expectation_suite with add Feb 13, 2024
@aquemy aquemy self-requested a review February 13, 2024 09:24
@aquemy aquemy changed the title fix: #1504 - switch create_expectation_suite with add fix: switch create_expectation_suite with add Feb 13, 2024
@aquemy
Copy link
Contributor

aquemy commented Feb 13, 2024

Thank you for your contribution! 🥇

@aquemy aquemy merged commit 98d0866 into ydataai:develop Feb 13, 2024
15 of 24 checks passed
@nadavshatz nadavshatz deleted the patch-1 branch February 13, 2024 14:57
fabclmnt added a commit that referenced this pull request Apr 5, 2024
* chore(actions): update actions/cache action to v4

* fix: comparison to_json pd.Series encoding error (#1538)

* fix: comparison to_json pd.Series encoding error

* fix(linting): code formatting

* fix: unit test

* fix(linting): code formatting

---------

Co-authored-by: Azory YData Bot <azory@ydata.ai>

* closes #1504 - switch create_expectation_suite with add_expectation_suite (#1540)

* fix: timeseries gap comparison failing with no gaps for date index (#1551)

* fix: ts gap comparison failing with no gaps

* fix(linting): code formatting

---------

Co-authored-by: Azory YData Bot <azory@ydata.ai>

* chore: readme

* docs: update docs readme.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Barros <alexbarros@users.noreply.github.com>
Co-authored-by: Azory YData Bot <azory@ydata.ai>
Co-authored-by: Nadav Shatz <nadav@tailorbrands.com>
Co-authored-by: Fabiana Clemente <fabianaclemente@Fabianas-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'FileDataContext' object has no attribute 'create_expectation_suite'
2 participants