Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type schema not checking for empty columns #1679

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

alexbarros
Copy link
Contributor

@alexbarros alexbarros commented Dec 5, 2024

Type schema did not check for empty columns leading to errors when trying to calculate some metrics over it. Also updates the type of an unsupported column when the type was defined by the user.
e.g. for columns:

df = pd.DataFrame({
    'date': ['0001-01-01', '9999-12-31', '2012-10-03', '2017-10-03', '2022-10-03', '2022-10-04'],
    'null': [None]*6,
})

image

@alexbarros alexbarros requested a review from fabclmnt December 5, 2024 13:03
Copy link
Contributor

@fabclmnt fabclmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@alexbarros alexbarros merged commit f3bc959 into develop Dec 6, 2024
12 of 14 checks passed
@alexbarros alexbarros deleted the fix/type_schema_error_with_null_cols branch December 6, 2024 15:30
portellaa pushed a commit that referenced this pull request Dec 8, 2024
* fix: type schema not checking for empty columns

* fix: remove alerts unused parameters

* fix: indicate user defined type on empty columns

* fix(linting): code formatting

---------

Co-authored-by: Azory YData Bot <azory@ydata.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants