Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejected Columns based on co-relation type #299

Closed
wants to merge 6 commits into from
Closed

Rejected Columns based on co-relation type #299

wants to merge 6 commits into from

Conversation

akhildevelops
Copy link

@akhildevelops akhildevelops commented Dec 27, 2019

This PR is raised against to the Feature Request raised: #298

Helps in selecting type of Co-relation to be used in rejected Columns.

'pearson', 'spearman', 'kendall', 'phi_k'

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9e09a8d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #299   +/-   ##
=========================================
  Coverage          ?   91.97%           
=========================================
  Files             ?       41           
  Lines             ?     1271           
  Branches          ?        0           
=========================================
  Hits              ?     1169           
  Misses            ?      102           
  Partials          ?        0
Flag Coverage Δ
#issue 81.19% <16.66%> (?)
#unit 88.31% <100%> (?)
Impacted Files Coverage Δ
pandas_profiling/__init__.py 86.48% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e09a8d...4350326. Read the comment docs.

@sbrugman
Copy link
Collaborator

sbrugman commented Jan 1, 2020

Great addition, thank you.

Your pull request points out an inconsistency in the current implementation w.r.t. correlation rejection. In addition to this part of the code, describe.py also rejects columns based on a correlation threshold.

The issue #284 is also related.

This PR is a great start to resolve these three points at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants