Skip to content

Commit

Permalink
* Added session info into trace.TableSessionBulkUpsertStartInfo
Browse files Browse the repository at this point in the history
  • Loading branch information
asmyasnikov committed Oct 8, 2024
1 parent 84e9735 commit f1535f0
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Added session info into `trace.TableSessionBulkUpsertStartInfo`

## v3.84.0
* Added `meta.WithTraceParent` context modifier for explicit putting traceparent header into grpc calls

Expand Down
5 changes: 2 additions & 3 deletions internal/table/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -1258,9 +1258,8 @@ func (s *session) BulkUpsert(ctx context.Context, table string, rows value.Value
var (
a = allocator.New()
callOptions []grpc.CallOption
onDone = trace.TableOnSessionBulkUpsert(
s.config.Trace(), &ctx,
stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table.(*session).BulkUpsert"),
onDone = trace.TableOnSessionBulkUpsert(s.config.Trace(), &ctx,
stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/table.(*session).BulkUpsert"), s,
)
)
defer func() {
Expand Down
2 changes: 2 additions & 0 deletions trace/table.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ type (
// Safe replacement of context are provided only inside callback function
Context *context.Context
Call call

Session sessionInfo
}
// Internals: https://github.com/ydb-platform/ydb-go-sdk/blob/master/VERSIONING.md#internals
TableSessionBulkUpsertDoneInfo struct {
Expand Down
30 changes: 29 additions & 1 deletion trace/table_gtrace.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f1535f0

Please sign in to comment.