-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve logging system in terminal and UI #540
feat: improve logging system in terminal and UI #540
Conversation
…nsaction-hash # Conflicts: # backend/protocol_rpc/endpoints.py # tests/common/transactions.py
…ion-id-with-transaction-hash # Conflicts: # backend/protocol_rpc/endpoints.py
@denishacquin please also fix backend unit tests |
@@ -149,7 +149,6 @@ def set_transaction_result(self, transaction_hash: str, consensus_data: dict): | |||
self.session.query(Transactions).filter_by(hash=transaction_hash).one() | |||
) | |||
|
|||
transaction.status = TransactionStatus.FINALIZED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was redundant because we also update the status in the update status method, and I thought it was causing the unit test to fail. But actually updating the mocking in the test was enough, so I'm reverting this! nevermind
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
...nd/database_handler/migration/versions/a32f85df2806_add_client_session_id_to_transactions.py
Show resolved
Hide resolved
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Signed-off-by: Agustín Ramiro Díaz <agustin.ramiro.diaz@gmail.com>
Quality Gate failedFailed conditions |
🎉 This PR is included in version 0.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes #448
Fixes #436
What
Here's the list of events that trigger logs:
Why
Testing done
Decisions made
Checks
Reviewing tips
User facing release notes