fix: Resolve invalid next config warning #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded next-pwa dependency minor version to solve invalid config warning in next.config.js
0xMirim
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…descriptions into fix-invalid-config
Upgraded next-pwa dependency minor version (5.5.5 -> 5.6.0 [breaking] ) to solve invalid config warning in next.config.js
|
@Majorfi This PR is ready for review (equivalent PR is also present in web-template repo will also tag you there) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I upgraded the next-pwa dependency (5.5.4 -> 5.6.0) to solve an invalid config warning from next.config.js. This warning (image below) was consistently visible when running the site with yarn dev. This issue had been experienced by others and had been reported to the next-pwa maintainers who addressed it in the release 5.5.5.
Release 5.6.0 was the latest release at the time I went to update this dependency. It is listed as a breaking change but only required minor modification to the next.config.js file. My thought is that running latest version of dependencies is good as long as it doesn't cause additional issues, so I upgraded to the latest. The original warning is no longer present and the site continues to work as normal.
Type of change
Change details
N/A
Resources
next-pwa 5.6.0 Release Notes
next-pwa 5.5.5 Release Notes