[REF] Refactor segmentation code into many files and pimms system #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36000
changed the title
|
@arokem this is ready for review/merge |
arokem
reviewed
May 2, 2024
36000
commented
May 2, 2024
|
I think this is good to go, lets wait for #1124 |
|
@arokem i added some testing and modified the criteria system to not use pimms |
arokem
reviewed
May 23, 2024
|
@arokem this is ready for another round of review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the massive segmentation class into many files. It should make it a lot easier to change segmentation code in the future, ie, to make it so bundles can depend on the position of other bundles. It also makes recobundles into "just another" step in the pipeline, not as an entirely separate pipeline.