[FIX] different CST ROI 2 for L/R #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
OK - just to document what is going on here: in the current software, the inferior ROI for CST contains waypoints in both the left and the right hemispheres. However, because we are excluding streamlines that cross the midline, it makes no sense to have a waypoint in the opposite hemisphere. This PR points the software to new waypoint ROIs that only have voxels in the relevant hemisphere for each CST. Is that correct, @36000? Does that make sense to you as well, @jyeatman? |
|
This is correct |
|
Previously we split fibers that crossed rather than excluding them and that’s why the ROIs were in both hemispheres. But this is fine
Jason D. Yeatman, Ph.D.<https://profiles.stanford.edu/jason-yeatman>
Associate Professor
Stanford University, Graduate School of Education and Department of Psychology
Stanford School of Medicine, Division Developmental Behavioral Pediatrics
Brain Development & Education Lab<http://brainandeducation.com/>
…________________________________
From: John Kruper ***@***.***>
Sent: Saturday, May 18, 2024 10:18:00 AM
To: yeatmanlab/pyAFQ ***@***.***>
Cc: Jason Daniel Yeatman ***@***.***>; Mention ***@***.***>
Subject: Re: [yeatmanlab/pyAFQ] [FIX] different CST ROI 2 for L/R (PR #1138)
This is correct
—
Reply to this email directly, view it on GitHub<#1138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AANRRSVTOFO4NCQZD6SWOM3ZC6EMRAVCNFSM6AAAAABH5TACAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYHA4DKMZWGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
arokem
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.