[WIP]Update from DataStreams to Tables #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great contribution, thanks! Let us know when it's ready for review. I didn't know NamedTupleTools before, but I see you are using it to simplify namedtuple creation, is that right? If it's just that, I would probably prefer not to take on an extra dependency for that reason. |
|
Thanks for looking into it. I was facing a bit of problem with the types, so hastily used the NamedTupleTools. I also added it so that I can simplify the benchmarks that I talked about. I'll have it sorted out before merging. :) |
|
Rest of the commits will be made in #117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.