Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a kwarg to set OSRAxisMappingStrategy #120

Merged
merged 6 commits into from
Jun 3, 2020
Merged

Conversation

rafaqz
Copy link
Collaborator

@rafaqz rafaqz commented May 11, 2020

This is a first pass at setting OSRAxisMappingStrategy with a keyword argument.

I'm not sure how to implement it for fromWKT etc methods, where the @gdal macro is used, so some input on that would be helpful.

But otherwise it works for reprojecting points.

The default is :trad now for testing, but we can change that to :compliant depending on what people want the default behaviour to be for ArchGDAL

closes #119

src/ogr/geometry.jl Outdated Show resolved Hide resolved
@rafaqz
Copy link
Collaborator Author

rafaqz commented May 13, 2020

This is now just reproject, importCRS and newspatialref. :compliant is the default so that nothing changes fro current behaviour unless users specify :trad in either of those methods.

Also ready to merge.

@rafaqz rafaqz changed the title WIP add a kwarg to set OSRAxisMappingStrategy Add a kwarg to set OSRAxisMappingStrategy May 13, 2020
src/spatialref.jl Outdated Show resolved Hide resolved
src/spatialref.jl Outdated Show resolved Hide resolved
src/spatialref.jl Outdated Show resolved Hide resolved
Copy link
Owner

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update https://github.com/yeesian/ArchGDAL.jl/blob/master/docs/src/projections.md with documentation on GeoFormat and these changes as well?

@coveralls
Copy link

coveralls commented May 26, 2020

Coverage Status

Coverage decreased (-0.05%) to 91.312% when pulling df0cb95 on rafaqz:axisorder into 2186d3a on yeesian:master.

@rafaqz
Copy link
Collaborator Author

rafaqz commented May 26, 2020

Your comments are resolved and code/docs are cleaned up.

Can we update https://github.com/yeesian/ArchGDAL.jl/blob/master/docs/src/projections.md with documentation on GeoFormat and these changes as well?

I barely have time to do this PR currently, I'm not sure when I would be able to do that.

@rafaqz
Copy link
Collaborator Author

rafaqz commented Jun 2, 2020

Can you merge this?

@yeesian yeesian merged commit cbb603f into yeesian:master Jun 3, 2020
@yeesian
Copy link
Owner

yeesian commented Jun 3, 2020

Thanks! Yeah the documentation is not a blocker, thanks for the ping!

@rafaqz
Copy link
Collaborator Author

rafaqz commented Jun 3, 2020

Actually good you waited a while as I found those extra bugs in the meantime :)

@rafaqz
Copy link
Collaborator Author

rafaqz commented Jun 3, 2020

Oh can we get a release as well? Trying to get GeoData.jl published.

@rafaqz rafaqz deleted the axisorder branch October 28, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importEPSG and importEPSGA both swap axis order to lat/lon
3 participants