Decreasing test size #121
Merged
Decreasing test size #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remotefiles.jl now doesn't download same files (equal sha signatures). Also changed 2 lines of code, such that the tests now run on non-redundant data-sets.
remotefiles.jl now doesn't download the datasets that are not used in any test
|
Looks good, test are passing :) |
As suggested [here](yeesian#121 (comment)), deleted the lines instead of commenting out
|
Great, thanks. What it the reason that you marked it WIP, work in progress? Do you still want to make other changes in this PR, or is this good to go? |
|
It is good to go now. I used the WIP tag in case I needed to make further changes. |
|
As long as you think you are done, you can leave it out. Otherwise people may wait for you to finish :) |
|
Many thanks Pritam! :) |
pritamd47
added a commit
to pritamd47/ArchGDAL.jl
that referenced
this pull request
Jun 2, 2020
* Removed Duplicates remotefiles.jl now doesn't download same files (equal sha signatures). Also changed 2 lines of code, such that the tests now run on non-redundant data-sets. * Removed files which were not used for testing remotefiles.jl now doesn't download the datasets that are not used in any test * Deleted commented out lines As suggested [here](yeesian#121 (comment)), deleted the lines instead of commenting out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #104, testing ArchGDAL requires around 200MB of datasets to be downloaded.
The objective of this PR is to tackle this issue.
As suggested by @visr here in an earlier PR with the same objective, this PR is much cleaner.