[test] Replace Pkg.PlatformEngine --> Custom download & verify #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zerefwayne <aayushjog@gmail.com>
|
Sorry for the late response -- is this PR ready to be reviewed? I saw the test failures on Travis and wasn't sure if you still have work-in-progress. I dug into the logs on Travis and think they were due to flakey tests that @visr pointed out in #158 and have updated the test values in #157. I think this PR might work if you rebase it on master. |
41 tasks
|
This has been incorporated into #179, thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zerefwayne aayushjog@gmail.com
closes #154
Replaced the internal functions of Pkg with custom functions with only the functionalities we require. The implementation is inspired by Pkg.PlatformEngines and uses the upcoming
Downloads.download()which will be the de-facto from Julia v1.6Adds
DownloadsandSHAto Test dependencies.No new test cases break reported.
Before the Change:
1226 passed, 12 failed, 0 errored, 0 broken.After the Change:
1226 passed, 12 failed, 0 errored, 0 broken.