Add support for complex gdal data type #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds GDT_CFloat* to the supported types in the conversion.
Closed
yeesian
reviewed
Jun 24, 2021
yeesian
approved these changes
Jun 24, 2021
felixcremer
force-pushed
the
complextypes
branch
from
d7ddfe6
to
6ed8afd
Compare
See e.g. https://stackoverflow.com/a/5813359 for rationale.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GDT_CFloat* to the supported types in the conversion and allows to load complex raster data.
I am not sure, whether the test case in tests_rasterio.jl is at the correct place, but I wanted to test whether the reading and writing of complex data works because the test in test_types.jl also works currently without conversion.
This would partially close #170.