Bugfix for dataset ownership when creating layers #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should have a corresponding dataset for "floating layers" that were constructed "layer-first"
|
I'm happy to see the bug fixed! However, it is unclear to me how to know which parts of (Arch)GDAL need such a fix. Was this an oversight, is it my own coding style in GeoDataFrames? If the non interactive (I) version of FeatureLayer needs an owner, might RasterBand also need it? |
evetion
approved these changes
Jul 5, 2021
|
I've opened #215 for tracking #214 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212.
I'll think about a more systematic way of catching such classes of bugs in #171, but just wanted to address the reported bug first.