-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Return missing
if the field is set but null.
#238
Commits on Aug 31, 2021
-
Return
missing
if the field is set but null.Fixes #177 . I think this aligns the behavior a lot better across the different file formats (see the test sets in test/test_tables.jl) This behavior is implemented through `getfield(feature, i)` which makes use of `getfieldtype(feature, i)`. That way, we are aligned in behavior for field subtypes even for e.g. displaying the fields. Because a lot hinges on distinguishing between whether a field is set versus whether it is null (see Toblerity/Fiona#460 (comment)), I have also added support for `isfieldnull()`, `isfieldsetandnotnull()`, and `setfieldnull!()`.
Configuration menu - View commit details
-
Copy full SHA for 042fab2 - Browse repository at this point
Copy the full SHA 042fab2View commit details
Commits on Sep 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e59dd31 - Browse repository at this point
Copy the full SHA e59dd31View commit details
Commits on Sep 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f18c8c6 - Browse repository at this point
Copy the full SHA f18c8c6View commit details -
Add tests and implementation for getfield with missing values
As mathieu has observed, `OGRUnsetMarker` and `OGRNullMarkerare` are mutually exclusive. We implement that case to return nothing if it ever comes up, but it is not possible for us to the corresponding code path.
Configuration menu - View commit details
-
Copy full SHA for bc2f038 - Browse repository at this point
Copy the full SHA bc2f038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9584962 - Browse repository at this point
Copy the full SHA 9584962View commit details -
Configuration menu - View commit details
-
Copy full SHA for efd22c7 - Browse repository at this point
Copy the full SHA efd22c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 763d839 - Browse repository at this point
Copy the full SHA 763d839View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63b6f98 - Browse repository at this point
Copy the full SHA 63b6f98View commit details
Commits on Sep 25, 2021
-
Map unset fields to
nothing
and null values tomissing
Because getdefault() is meant to be used only when setting fields for notnullable columns with missing values, we make it return `nothing` instead of `missing` to unset the field.
Configuration menu - View commit details
-
Copy full SHA for 08ffc27 - Browse repository at this point
Copy the full SHA 08ffc27View commit details
Commits on Sep 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 364f171 - Browse repository at this point
Copy the full SHA 364f171View commit details -
use isfieldset() and isfieldnull() when getting a field
isfieldsetandnotnull() is just a convenience function.
Configuration menu - View commit details
-
Copy full SHA for 323cbdb - Browse repository at this point
Copy the full SHA 323cbdbView commit details -
raise an error instead of getting default if we do not recognize the …
…fieldtype when reading the field (in the future, we will switch to dispatch on the fieldtype rather than the current dictionary approach, but that is out of the scope of this commit.)
Configuration menu - View commit details
-
Copy full SHA for 5c7b677 - Browse repository at this point
Copy the full SHA 5c7b677View commit details -
Configuration menu - View commit details
-
Copy full SHA for 092bed4 - Browse repository at this point
Copy the full SHA 092bed4View commit details
Commits on Sep 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a7710c2 - Browse repository at this point
Copy the full SHA a7710c2View commit details