Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table to IFeatureLayer #243

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Table to IFeatureLayer #243

wants to merge 45 commits into from
+881 −43

Commits on Oct 12, 2021

  1. 1st draft of an IFeatureLayer constructor from table

    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    fd7eeec View commit details
    Browse the repository at this point in the history

  2. Fixed IFeatureLayer(table) for tables not supporting view on row (e.g… 

    …. NamedTuple)
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    163e9b8 View commit details
    Browse the repository at this point in the history

  3. Test table to IFeatureLayer conversion with amissing, mixed geome… 

    …tries, mixed float/int

Test with `nothing` skipped until PR yeesian#238 [Breaking] Return missing if the field is set but null. is merged
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    9e0e900 View commit details
    Browse the repository at this point in the history

  4. Fixed handling of type Any in a column and modified error messages 

    Added some test coverage on convert error cases:
-  ogrerr macro error message modification
- IFeature(table) constructor errors on type conversions
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    91e3a10 View commit details
    Browse the repository at this point in the history

  5. Fixed conversion to OGRFieldType error handing 

    Added a test on OGRFieldType error handing
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    a79ec71 View commit details
    Browse the repository at this point in the history

  6. JuliaFormatter formating

    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    843155d View commit details
    Browse the repository at this point in the history

  7. Handling of Tables.schema returning nothing or `Schema{names, not… 

    …hing}`
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    d8849e4 View commit details
    Browse the repository at this point in the history

  8. Added basic conversion to layer documentation in "Tables interface" s… 

    …ection
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    a5090a0 View commit details
    Browse the repository at this point in the history

  9. Completed doc on conversion to layer with an example of writing to a … 

    …file, illustrating the data modification that may be induced by the driver limitations (here "ESRI Shapefile")
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    848fe0e View commit details
    Browse the repository at this point in the history

  10. Added in doc an example of writing to the GML more capable driver

    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    0bd76de View commit details
    Browse the repository at this point in the history

  11. Fixed a typo in table docs

    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    2045d55 View commit details
    Browse the repository at this point in the history

  12. Added docstring with example to IFeatureLayer(table) 

    Adjusted prerequisite
Added layer name option to IFeatureLayer
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    a6277af View commit details
    Browse the repository at this point in the history

  13. Formatted with JuliaFormatter

    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    5035a0e View commit details
    Browse the repository at this point in the history

  14. Fixed a typo on name option for IFeatureLayer(table)

    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    541ff9b View commit details
    Browse the repository at this point in the history

  15. Added nothing values handling (cf. PR yeesian#238): 

    - no difference for geometry columns. Both `nothing` and `missing` values map to an UNSET geometry field (null pointer)
- field set to NULL for `missing` values and not set for `nothing` values
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    1b6ab33 View commit details
    Browse the repository at this point in the history

  16. _fromtable function code readability enhancements: 

    - refactored conversion of table column types to ArchGDAL layer featuredefn's geomfield and field types
- added docstrings
- adjusted convert fonctions between `OGRFieldType`s / `OGRFieldSubType`s and `DataType`s to enable refactoring
    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    7fa434c View commit details
    Browse the repository at this point in the history

  17. Fixed a typo in _fromtable column types conversion error message

    @mathieu17g
    mathieu17g committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    8f8b1bd View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Corrections following @yeesian review

    @mathieu17g
    mathieu17g committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    0e12703 View commit details
    Browse the repository at this point in the history

  2. Fixed arg type in ctv_toWKT signature ("Table to layer conversion" … 

    …testset)
    @mathieu17g
    mathieu17g committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6454e09 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2021

  1. Added GeoInterface geometries handling to table to layer conversion

    @mathieu17g
    mathieu17g committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    8f07154 View commit details
    Browse the repository at this point in the history

  2. Fixed typo in GeoInterface to IGeometry conversion and added tests on it

    @mathieu17g
    mathieu17g committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    a4bd378 View commit details
    Browse the repository at this point in the history

  3. Added tests on GeoInterface geometries types to OGRwkbGeometryType

    @mathieu17g
    mathieu17g committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    7166097 View commit details
    Browse the repository at this point in the history

  4. Formatting and cleaning

    @mathieu17g
    mathieu17g committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    33c3a76 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Added WKT and WKB parsing options in table to layer conversion

    @mathieu17g
    mathieu17g committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    0b1b9d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Enhance test coverage by pruning handling of Vector{String} convers… 

    …ion to `IGeometry` and empty table conversion to layer
    @mathieu17g
    mathieu17g committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    f8da022 View commit details
    Browse the repository at this point in the history

  2. Corrected a typo in _fromtable

    @mathieu17g
    mathieu17g committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    c0e4da6 View commit details
    Browse the repository at this point in the history

  3. Extended test coverage by testing individually GeoInterface, WKT, WKB… 

    … cases
    @mathieu17g
    mathieu17g committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    77d561d View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Merge branch 'master' into IFeatureLayer_from_table

    @mathieu17g
    mathieu17g committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    a33bc88 View commit details
    Browse the repository at this point in the history

  2. Folliowing @visr and @yeesian remarks: 

    - modified Project.toml dep order
- fixed a typo in `_fromtable` comments
- transformed notes into `!!! warning` in tables.md doc
    @mathieu17g
    mathieu17g committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    b08919b View commit details
    Browse the repository at this point in the history

  3. Fixed test_tables.jl to use layer_name kwarg instead of name to c… 

    …onform to modification made in commit b08919b
    @mathieu17g
    mathieu17g committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    d41cbc2 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Added geometry column specification kwarg geom_cols, without any te… 

    …sting beyond already existing tests which have been adapted
    @mathieu17g
    mathieu17g committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    1ff0196 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. Added fieldtypes kwarg option to table to layer conversion, without… 

    … any specific tests yet
    @mathieu17g
    mathieu17g committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    125a076 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2021

  1. Added tests on geomcols kwarg and corrected issues revealed while a… 

    …dding tests
    @mathieu17g
    mathieu17g committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    9e90dc1 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. A few issue fixes while adding test to fieldtypes kwarg option.

    @mathieu17g
    mathieu17g committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    f57a867 View commit details
    Browse the repository at this point in the history

  2. Added test on fieldtypes kwarg and fixed issues raised by those tests

    @mathieu17g
    mathieu17g committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    8911988 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Added error message test in @test_throws tests for fieldtypes and… 

    … `geomcols` kwargs.

Ajusted error messages syntax
    @mathieu17g
    mathieu17g committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    fbb4618 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Merge branch 'master' into IFeatureLayer_from_table

    @mathieu17g
    mathieu17g committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    1d39170 View commit details
    Browse the repository at this point in the history

  2. Modified conversion from GeoInterface.AbstracGeometry to IGeometry 

    - Moved from `@generated` to normal functions
- Added conversion for `GeoInterface.AbstractGeometryCollection`
- Differentiated display between `IGeometry` and `Geometry`
- Added tests on compact display for `AbstracGeometry` (e.g in use in DataFrames)
    @mathieu17g
    mathieu17g committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    5cd1f16 View commit details
    Browse the repository at this point in the history

  3. Exclude columns in fieldtypes from WKT/WKB parsing in `_infergeomet… 

    …ryorfieldtypes`
    @mathieu17g
    mathieu17g committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    d08a47c View commit details
    Browse the repository at this point in the history

  4. Typo in the previous commit spfieldtypes intead of fieldtypes

    @mathieu17g
    mathieu17g committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    ad14efd View commit details
    Browse the repository at this point in the history

  5. Deleted 2 comments in `_fromtable(sch::Tables.Schema{names,types}, ..… 

    ….)` following @yeesian comments
    @mathieu17g
    mathieu17g committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    0c61b85 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. Dropped fieldtypes kwarg in src and tests

    @mathieu17g
    mathieu17g committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    60df39e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into IFeatureLayer_from_table

    @mathieu17g
    mathieu17g committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    a197973 View commit details
    Browse the repository at this point in the history

  3. Refixed ogrerr macro

    @mathieu17g
    mathieu17g committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    6ae870c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. Dropped geomcols kwarg and WKT/WKB parsing in src/ and test/

    @mathieu17g
    mathieu17g committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    e8560e4 View commit details
    Browse the repository at this point in the history