Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified benchmark.yml to benchmark last commit against master, instead of against itself as has to be done in jumpstart PR #248 #249

Merged
merged 2 commits into from
Oct 9, 2021

Conversation

mathieu17g
Copy link
Collaborator

In commit #248, I had to restrict benchmark of the last commit to itself since the benchmark configuration as not present in master before merge.

Now every new commit should be benchmarked to master

…ad of against itself as has to be done in jumpstart PR yeesian#248
@mathieu17g mathieu17g marked this pull request as ready for review October 8, 2021 05:01
@yeesian yeesian merged commit 58e2073 into yeesian:master Oct 9, 2021
@yeesian
Copy link
Owner

yeesian commented Oct 9, 2021

Thank you!

1 similar comment
@yeesian
Copy link
Owner

yeesian commented Oct 9, 2021

Thank you!

@mathieu17g mathieu17g deleted the benchmark_ci_2nd_pass branch October 9, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants