update tests for GDAL 3.4 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's okay to move to GDAL 3.4 when that happens. It'll have to be a new release, so that users of previous GDAL versions can still be pinned to it if they want? |
|
Yeah indeed, that will be easiest for us as well. GDAL.jl will get a minor (non breaking) release. |
|
I pushed a commit that bumps the ArchGDAL minor version to v0.8.0. Since ArchGDAL is pre-v1 it is my understanding that it needs to be a breaking/minor release. Though if you prefer to include other changes in v0.8.0 we could hold off on this as well. |
evetion
approved these changes
Jan 13, 2022
|
I do not have any other plans for v0.8, so this PR looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fail for now, since JuliaGeo/GDAL.jl#131 is not yet merged and tagged. But locally this works using that branch.
GDAL.jl is dropping julia 1.5 and older support in that PR. As long as ArchGDAL doesn't use features that are only available in GDAL 3.4, it is fine to keep the current GDAL and julia compat in Project.toml, though then perhaps this PR should be made in a way that it will pass tests on julia 1.3 as well.