Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OFSTJSON when fetching fields #342

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Add support for OFSTJSON when fetching fields #342

merged 1 commit into from
Oct 31, 2022

Conversation

yeesian
Copy link
Owner

@yeesian yeesian commented Oct 31, 2022

Fixes #341

@yeesian yeesian mentioned this pull request Oct 31, 2022
Closed
@yeesian yeesian requested a review from visr October 31, 2022 03:42
visr
visr approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nightly failure, type Stateful has no field taken, is unrelated.

@yeesian yeesian merged commit fe28197 into master Oct 31, 2022
@yeesian yeesian deleted the b341 branch October 31, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

@evetion evetion evetion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OFSTJSON not implemented in getfield
3 participants
@yeesian @visr @evetion