Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax type constraint in unsafe_executesql #364

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

maxfreu
Copy link
Contributor

@maxfreu maxfreu commented Jan 18, 2023

Hi! I just switched the spatialfilter type constraint to AbstractGeometry, so that one can use IGeometry{wkbPolygon} as filter. I hope this is valid; at least it seems to work.

Copy link
Owner

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah that looks reasonable to me :)

@yeesian yeesian merged commit 7710f38 into yeesian:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants