Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop to v1.69.2 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 31, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) '1.67.0' -> '1.69.2' age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.69.2

Compare Source

Bug fixes
  • #​13553: Fix an incorrect autocorrect for Style/MultipleComparison when a variable is compared multiple times after a method call. ([@​koic][])
  • #​13562: Fix Bundler/DuplicatedGem cop error in case of empty branch. ([@​viralpraxis][])
  • #​13573: Fix Lint/UnescapedBracketInRegexp cop failure with invalid multibyte escape. ([@​earlopain][])
  • #​13556: Fix false positives for Style/FileNull when using 'nul' string. ([@​koic][])
  • #​12995: Fix --disable-uncorrectable to not insert directives inside a string. ([@​dvandersluis][])
  • #​13320: Fix incorrect autocorrect when Layout/LineContinuationLeadingSpace and Style/StringLiterals autocorrects in the same pass. ([@​dvandersluis][])
  • #​13299: Fix Style/BlockDelimiters to always accept braces when an operator method argument is chained. ([@​dvandersluis][])
  • #​13565: Fix Style/RedundantLineContinuation false negatives when a redundant continuation follows a required continuation. ([@​dvandersluis][])
  • #​13551: Fix an incorrect autocorrect for Style/IfWithSemicolon when using multi value assignment in if with a semicolon is used. ([@​koic][])
  • #​13534: Fix Layout/LineLength cop failure in case of YARD-comment-like string. ([@​viralpraxis][])
  • #​13558: Fix Lint/NonAtomicFileOperation cop error in case of implicit receiver. ([@​viralpraxis][])
  • #​13564: Fix Metrics/ClassLength cop error in case of chained assignments. ([@​viralpraxis][])
  • #​13570: Fix Naming/RescuedExceptionsVariableName cop error when exception is assigned with writer method. ([@​viralpraxis][])
  • #​13559: Fix a false positive for Style/RedundantLineContinuation when a method definition is used as an argument for a method call. ([@​davidrunger][])
  • #​13574: Fix Style/ExactRegexpMatch cop error on invalid regular expression literal. ([@​viralpraxis][])
  • #​13554: Fix Style/FrozenStringLiteralComment false positive in case of non-downcased value literal. ([@​viralpraxis][])
  • #​13569: Fix Style/MethodCallWithoutArgsParentheses cop error in case of mass hash assignment. ([@​viralpraxis][])
  • #​13542: Fix Style/RedundantCondition cop failure in case of empty arguments. ([@​viralpraxis][])
  • #​13509: Update Layout/ExtraSpacing and Layout/SpaceAroundOperators to handle preceding operators inside strings. ([@​dvandersluis][])

v1.69.1

Compare Source

Bug fixes
  • #​13502: Fix an incorrect autocorrect for Style/DigChain when using safe navigation method chain with dig method. ([@​koic][])
  • #​13505: Fix an error for Style/ParallelAssignment when using the anonymous splat operator. ([@​earlopain][])
  • #​13184: Fix some false positives in Lint/UnreachableCode. ([@​isuckatcs][])
  • #​13494: Fix false positives for Style/HashExcept cop when using reject/!include?, reject/!in? or select/!exclude? combinations. ([@​lovro-bikic][])
  • #​13522: Fix Lint/UnescapedBracketInRegexp cop failure with invalid regular expression. ([@​viralpraxis][])
  • #​13523: Fix Style::AccessModifierDeclarations cop failure in case of if node without else. ([@​viralpraxis][])
  • #​13524: Fix Style/RedundantArgument cop failure while inspecting string literal with invalid encoding. ([@​viralpraxis][])
  • #​13528: Fix Style/RedundantParentheses cop failure in case of splatted case node without condition. ([@​viralpraxis][])
  • #​13521: Fix Style/RedundantSelf cop failure with kwnilarg argument node. ([@​viralpraxis][])
  • #​13526: Fix Style/StringConcatenation cop failure when there are mixed implicit and explicit concatenations. ([@​viralpraxis][])
  • #​13511: Fix false positive in Lint/UnescapedBracketInRegexp when using regexp_parser 2.9.2 and earlier. ([@​dvandersluis][])
  • #​13096: Update Style/BlockDelimiters to not change braces when they are required for syntax. ([@​dvandersluis][])
  • #​13512: Update Style/LambdaCall to be aware of safe navigation. ([@​dvandersluis][])

v1.69.0

Compare Source

New features
Bug fixes
  • #​13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. ([@​koic][])
  • #​13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. ([@​koic][])
  • #​13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@​dak2][])
  • #​13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. ([@​koic][])
  • #​13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. ([@​koic][])
  • #​13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. ([@​koic][])
  • #​13411: Fix Style/BitwisePredicate when having regular method. ([@​d4be4st][])
  • #​13432: Fix false positive for Lint/FloatComparison against nil. ([@​lovro-bikic][])
  • #​13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. ([@​koic][])
  • #​13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. ([@​koic][])
  • #​13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@​earlopain][])
  • #​13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. ([@​koic][])
  • #​13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. ([@​koic][])
  • #​13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@​dvandersluis][])
  • #​13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@​aduth][])
  • #​13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@​dvandersluis][])
  • #​13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@​dvandersluis][])
  • #​13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@​dvandersluis][])
  • #​13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@​lovro-bikic][])
  • #​13442: Fix an incorrect autocorrect for Style/NestedTernaryOperator when ternary operators are nested and the inner condition is parenthesized. ([@​koic][])
  • #​13444: Fix an incorrect autocorrect for Style/OneLineConditional when the else branch of a ternary operator has multiple expressions. ([@​koic][])
  • #​13483: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using escaped double quote character. ([@​koic][])
  • #​13497: Fix infinite loop error for Style/IfWithSemicolon when using nested if/;/end in if body. ([@​koic][])
  • #​13477: Update Layout/LeadingCommentSpace to accept multiline shebangs at the top of the file. ([@​dvandersluis][])
  • #​13453: Update Style/AccessModifierDeclarations to handle attr_* methods with multiple parameters. ([@​dvandersluis][])
  • #​12597: Update Style/SingleLineDoEndBlock to not register an offense if it will introduce a conflicting Layout/RedundantLineBreak offense. ([@​dvandersluis][])
Changes

v1.68.0

Compare Source

New features
Bug fixes
  • #​13401: Fix a false negative for Style/RedundantLineContinuation when there is a line continuation at the EOF. ([@​koic][])
  • #​13368: Fix an incorrect autocorrect for Naming/BlockForwarding with Style/ExplicitBlockArgument. ([@​koic][])
  • #​13391: Fix deserialization of unknown encoding offenses. ([@​earlopain][])
  • #​13348: Ensure Style/BlockDelimiters autocorrection does not move other code between the block and comment. ([@​dvandersluis][])
  • #​13382: Fix an error during error handling for custom ruby extractors when the extractor is a class. ([@​earlopain][])
  • #​13309: Fix a false negative for Lint/UselessAssignment cop when there is a useless assignment followed by a block. ([@​pCosta99][])
  • #​13255: Fix false negatives for Style/MapIntoArray when using non-splatted arguments. ([@​vlad-pisanov][])
  • #​13356: Fix a false positive for Layout/SpaceBeforeBrackets when there is a dot before []=. ([@​earlopain][])
  • #​13365: Fix false positives for Lint/SafeNavigationConsistency when using safe navigation on the LHS with operator method on the RHS of &&. ([@​koic][])
  • #​13390: Fix false positives for Style/GuardClause when using a local variable assigned in a conditional expression in a branch. ([@​koic][])
  • #​13337: Fix false positives for Style/RedundantLineContinuation when required line continuations for && is used with an assignment after a line break. ([@​koic][])
  • #​13387: Fix false positives in Style/RedundantParentheses when parentheses are used around method chain with do...end block in keyword argument. ([@​koic][])
  • #​13341: Fix false positives for Lint/SafeNavigationChain when a safe navigation operator is used with a method call as the RHS operand of && for the same receiver. ([@​koic][])
  • #​13324: Fix --disable-uncorrectable to not insert a comment inside a string continuation. ([@​dvandersluis][])
  • #​13364: Fix incorrect autocorrect with Lint/UselessAssignment a multiple assignment or for contains an inner assignment. ([@​dvandersluis][])
  • #​13353: Fix an incorrect autocorrect for Style/BlockDelimiters when EnforcedStyle: semantic is set and used with Layout/SpaceInsideBlockBraces. ([@​koic][])
  • #​13361: Fix false positives for Style/RedundantInterpolationUnfreeze and Style/RedundantFreeze when strings contain interpolated global, instance, and class variables. ([@​vlad-pisanov][])
  • #​13343: Prevent Layout/LineLength from breaking up a method with arguments chained onto a heredoc delimiter. ([@​dvandersluis][])
  • #​13374: Return exit code 0 with --display-only-correctable and --display-only-safe-correctable when no offenses are displayed. ([@​dvandersluis][])
  • #​13193: Fix false positive in Style/MultipleComparison when ComparisonsThreshold exceeds 2. ([@​fatkodima][],[@​vlad-pisanov][])
  • #​13325: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using a postfix unless for file existence checks before creating a file, in cases with Dir.mkdir. ([@​kotaro0522][])
  • #​13397: Update PercentLiteralCorrector to be able to write pairs of delimiters without excessive escaping. ([@​dvandersluis][])
  • #​13336: Update Style/SafeNavigation to not autocorrect if the RHS of an and node is an or node. ([@​dvandersluis][])
  • #​13378: When removing parens in Style/TernaryParentheses with a send node condition, ensure its arguments are parenthesized. ([@​dvandersluis][])
Changes
  • #​13347: When running rubocop -V, show the analysis Ruby version of the current directory. ([@​earlopain][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@yegor256
Copy link
Owner

@rultor please, try to merge, since 11 checks have passed

@rultor
Copy link
Collaborator

rultor commented Oct 31, 2024

@rultor please, try to merge, since 11 checks have passed

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
Copy link
Collaborator

rultor commented Oct 31, 2024

@rultor please, try to merge, since 11 checks have passed

@renovate[bot] @yegor256 Oops, I failed. You can see the full log here (spent 1min).

Installing rubocop 1.68.0
Fetching rubocop-rspec 3.2.0
Installing rubocop-rspec 3.2.0
Fetching simplecov-html 0.13.1
Installing simplecov-html 0.13.1
Fetching simplecov_json_formatter 0.1.4
Installing simplecov_json_formatter 0.1.4
Fetching simplecov 0.22.0
Installing simplecov 0.22.0
Fetching threads 0.4.0
Installing threads 0.4.0
Fetching yard 0.9.37
Installing yard 0.9.37
Bundle complete! 8 Gemfile dependencies, 25 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Run options: --seed 33974

# Running:

.......Errno::EADDRINUSE: Address already in use - bind(2) for "localhost" port 38597
	/home/r/repo/test/test_pool.rb:88:in `initialize'
	/home/r/repo/test/test_pool.rb:88:in `new'
	/home/r/repo/test/test_pool.rb:88:in `block (3 levels) in test_acquires_and_releases_in_threads'
	/home/r/repo/test/test_pool.rb:87:in `each'
	/home/r/repo/test/test_pool.rb:87:in `block (2 levels) in test_acquires_and_releases_in_threads'
	/home/r/repo/lib/random-port/pool.rb:117:in `block in acquire'
	/home/r/repo/lib/random-port/pool.rb:88:in `loop'
	/home/r/repo/lib/random-port/pool.rb:88:in `acquire'
	/home/r/repo/test/test_pool.rb:86:in `block in test_acquires_and_releases_in_threads'
	/usr/local/rvm/gems/ruby-3.2.2/gems/threads-0.4.0/lib/threads.rb:59:in `block (3 levels) in assert'
	/usr/local/rvm/gems/ruby-3.2.2/gems/threads-0.4.0/lib/threads.rb:54:in `loop'
	/usr/local/rvm/gems/ruby-3.2.2/gems/threads-0.4.0/lib/threads.rb:54:in `block (2 levels) in assert'
	/usr/local/rvm/gems/ruby-3.2.2/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:359:in `run_task'
	/usr/local/rvm/gems/ruby-3.2.2/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:350:in `block (3 levels) in create_worker'
	/usr/local/rvm/gems/ruby-3.2.2/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:341:in `loop'
	/usr/local/rvm/gems/ruby-3.2.2/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:341:in `block (2 levels) in create_worker'
	/usr/local/rvm/gems/ruby-3.2.2/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:340:in `catch'
	/usr/local/rvm/gems/ruby-3.2.2/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb:340:in `block in create_worker'
E...

Finished in 0.199283s, 55.1979 runs/s, 110.3959 assertions/s.

  1) Error:
RandomPort::TestPool#test_acquires_and_releases_in_threads:
RuntimeError: Only 99 out of 100 threads completed successfully
    /usr/local/rvm/gems/ruby-3.2.2/gems/threads-0.4.0/lib/threads.rb:73:in `assert'
    test/test_pool.rb:85:in `test_acquires_and_releases_in_threads'

11 runs, 22 assertions, 0 failures, 1 errors, 0 skips
Coverage report generated for Unit Tests to /home/r/repo/coverage.
Line Coverage: 98.52% (133 / 135)
rake aborted!
Command failed with status (1)
/usr/local/rvm/gems/ruby-3.2.2/gems/rake-13.2.1/exe/rake:27:in `<top (required)>'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `eval'
/usr/local/rvm/gems/ruby-3.2.2/bin/ruby_executable_hooks:22:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
container c1c9314c77b0837c3747c8acdb2b08926b300dc1078f933c5e5a2d1660b026f1 is dead
Thu Oct 31 10:35:17 UTC 2024

@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from a08cada to edfc1ba Compare November 26, 2024 19:33
@renovate renovate bot changed the title Update dependency rubocop to v1.68.0 Update dependency rubocop to v1.69.0 Nov 26, 2024
@renovate renovate bot changed the title Update dependency rubocop to v1.69.0 Update dependency rubocop to v1.69.1 Dec 3, 2024
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from edfc1ba to fd3a590 Compare December 3, 2024 15:13
@renovate renovate bot changed the title Update dependency rubocop to v1.69.1 Update dependency rubocop to v1.69.2 Dec 12, 2024
@renovate renovate bot force-pushed the renovate/rubocop-1.x branch from fd3a590 to 5f0c0cb Compare December 12, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants