Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate body declarations in the output #210

Closed
tmpfs opened this issue May 23, 2020 · 8 comments
Closed

Duplicate body declarations in the output #210

tmpfs opened this issue May 23, 2020 · 8 comments

Comments

@tmpfs
Copy link

tmpfs commented May 23, 2020

Just playing around with Tacit and I notice that certain styles are repeated in the generated output.

I downloaded the min.css version (current version linked in the README) and unminified it and see:

input,
textarea,
select,
button,
option,
html,
body {
    font-family: system-ui, "Helvetica Neue", Helvetica, Arial, sans-serif;
    font-size: 18px;
    font-stretch: normal;
    font-style: normal;
    font-weight: 400;
    line-height: 29.7px;
}

Repeated several times. I looked at the min.css file to check if the problem is with the unminifier and the duplications appear to exist there.

I am going to fix it manually for what I need to do, this is just to let you know you should check the SASS compiler output, something appears to be amiss.

@0crat
Copy link
Collaborator

0crat commented May 23, 2020

@filfreire/z please, pay attention to this issue

@yegor256
Copy link
Owner

@tmpfs can you please submit a pull request?

@filfreire
Copy link
Collaborator

@rultor release, tag is 1.5.5

@rultor
Copy link
Collaborator

rultor commented Mar 6, 2021

@rultor release, tag is 1.5.5

@filfreire OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Mar 6, 2021

@rultor release, tag is 1.5.5

@filfreire Done! FYI, the full log is here (took me 4min)

@filfreire
Copy link
Collaborator

@tmpfs as of tacit version 1.5.5 this issue should be fixed, thank you for reporting it! Closing this issue.

@yegor256 after adding a purging css step and removing duplicate rules, tacit minified version is now about 82% of its original size 😄

tacit

@0crat
Copy link
Collaborator

0crat commented Mar 6, 2021

Job gh:yegor256/tacit#210 is not assigned, can't get performer

@yegor256
Copy link
Owner

yegor256 commented Mar 7, 2021

@filfreire that's awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants