Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty fonts :) #169

Merged
merged 1 commit into from Jan 23, 2019
Merged

Pretty fonts :) #169

merged 1 commit into from Jan 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 18, 2018

Yay! Use pretty system fonts in modern browsers 😁

@0crat
Copy link
Collaborator

0crat commented Oct 18, 2018

@filfreire/z please, pay attention to this pull request

@ghost ghost changed the title Pretty fonts 😄 Pretty fonts :) Oct 18, 2018
@filfreire
Copy link
Collaborator

Hi @Edwr thank you for submitting a PR! 🙂

Any chance you can provide screenshots of the end-result?

@0crat
Copy link
Collaborator

0crat commented Oct 18, 2018

@Edwr/z this pull request is too small, just 2 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @filfreire/z please review this and merge or reject

@ghost
Copy link
Author

ghost commented Oct 19, 2018

Windows screenshot
windows-tacit.png
Ubuntu screenshot
ubuntu-tacit.png

system-ui uses the system font of the os (segoe-ui on windows and ubuntu on ubuntu).

Unfortunately I can't show you a screenshot from MacOS (I don't own a mac 😭).

@filfreire
Copy link
Collaborator

@Edwr looks good to me. Later today I'll see if I can test it on a Mac and if all is well I think we're clear to merge.

@yegor256 any issues on your side with this change?

@filfreire
Copy link
Collaborator

@Edwr sorry, forgot about following-up to this PR. Will do so ASAP.

@filfreire
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 23, 2019

@rultor merge

@filfreire OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2938dd6 into yegor256:master Jan 23, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 23, 2019

@rultor merge

@filfreire Done! FYI, the full log is here (took me 3min)

@0crat
Copy link
Collaborator

0crat commented Jan 23, 2019

Job gh:yegor256/tacit#169 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Jan 23, 2019

This job is not in scope

@filfreire
Copy link
Collaborator

@rultor release, tag is 1.3.8

@rultor
Copy link
Collaborator

rultor commented Jan 24, 2019

@rultor release, tag is 1.3.8

@filfreire OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jan 24, 2019

@rultor release, tag is 1.3.8

@filfreire Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants