-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default outline: 0 #173
Conversation
Hello, Having an outline of 0 makes the links and buttons unusable by keyboard and creates huge problems with accessibility http://www.outlinenone.com/
@filfreire/z please, pay attention to this pull request |
@SaraVieira this pull request is too small, just 1 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @filfreire/z please review this and merge or reject |
@rultor merge |
@filfreire OK, I'll try to merge now. You can check the progress of the merge here |
@filfreire Done! FYI, the full log is here (took me 3min) |
@rultor release, tag is |
@filfreire OK, I will release it now. Please check the progress here |
@filfreire Done! FYI, the full log is here (took me 3min) |
@SaraVieira thank you 👍 /cc @yegor256 |
Job |
This job is not in scope |
Thank you :D |
Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:
This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html
Thank you for your contribution!
Hello,
Having an outline of 0 makes the links and buttons unusable by keyboard and creates huge problems with accessibility
http://www.outlinenone.com/