Fix href handling @ Card

yentsun · Mar 26, 2024 · d22c0a0 · d22c0a0
1 parent 1e9df39
commit d22c0a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/components/Card.jsx b/src/components/Card.jsx
@@ -4,7 +4,9 @@ import useFetchData from '../hooks/useFetchData';
 
 export default function Card({ href, thumb, major, minor, content, isLoading }) {
 
-    return <div className="card" onClick={ () => window.location = href }>
+    const clickable = Boolean(href);  // for later use in tailwind classes
+
+    return <div className="card" onClick={ clickable ? () => window.location = href : ()=>{} }>
 
         { isLoading &&
         <h1>Loading...</h1> }

diff --git a/src/components/Cards/GitHub.jsx b/src/components/Cards/GitHub.jsx
@@ -6,7 +6,7 @@ export default function GitHub() {
 
     const { yentsun, lastEvent } = useGithub();
 
-    return <Card isLoading={ ! yentsun } thumb="github.gif"
+    return <Card isLoading={ ! yentsun } thumb="github.gif" href="https://github.com/yentsun"
                  major={`repos: ${yentsun?.public_repos}` }
                  minor={ `followers: ${yentsun?.followers}` }
                  content={ lastEvent