Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Upgrading autoprefixer to postcss. Fixes #1132 #1149

Merged
merged 1 commit into from
Jul 24, 2015

Conversation

bwaang
Copy link
Contributor

@bwaang bwaang commented Jul 24, 2015

Upgrading grunt-autoprefixer to grunt-postcss to remove deprecation warnings.

Added new npm package with post-css dependencies and removed deprecated grunt-autoprefixer. Fixes #1132

@eddiemonge
Copy link
Member

only problem is the commit message, it doesn't follow the contributing guidelines

Removes the deprecated grunt-autoprefixer with grunt-postcss.

Closes yeoman#1132
@bwaang
Copy link
Contributor Author

bwaang commented Jul 24, 2015

Oh sorry about that, fixed the commit message to the standard. Let me know if there's any other issue.

options: {
browsers: ['last 1 version']
processors: [
require('autoprefixer-core')({browsers: ['last 1 version']})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last 1 version

@eddiemonge Is this correct? IIRC we're still supporting IE9+, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of. This generator has always supported last 1 version. If people really want older IE support then they can change this themselves.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little strange that we lately dropped suppport for IE8 (7c6f245), while it in fact the support was IE10 anyways.

But yeah, I agree.

eddiemonge added a commit that referenced this pull request Jul 24, 2015
Upgrading autoprefixer to postcss. Fixes #1132
@eddiemonge eddiemonge merged commit 8a9a8af into yeoman:master Jul 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why angular generator doesn't already upgrade to postcss?
3 participants