This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
Fixed bug which caused buttons to have a height of 33px instead of 34px #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whats the issue with the buttons being 33px tall? |
|
@eddiemonge The heights don't match when an input is grouped with a button addon. |
|
Can you update your commit message according to the guidelines Sindre linked? |
peerb
added a commit
to peerb/generator-angular
that referenced
this pull request
Dec 21, 2013
Buttons now match the height of inputs, when using them as input groups. Previous [pull request](yeoman#500).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I had a strange bug today in my chrome browser which caused bootstrap buttons to have a height of 33px instead of the usual 34px. After some research, I found out that its a know issue and can be fixed by increasing the the precision of the sass compiler.
Cheers,
Peer
Found cause and fix here:
twbs/bootstrap-sass#409
gruntjs/grunt-contrib-compass#113