fix: fix engines to "^12.22.0 || ^14.17.0 || >=16.0.0" (#150)

yeonjuan · Oct 19, 2023 · d078d7e · d078d7e
1 parent 0fb394d
commit d078d7e
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 205 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -33,7 +33,8 @@
     "typescript": "^4.4.4"
   },
   "engines": {
-    "node": ">=8.10.0"
+    "node": "^12.22.0 || ^14.17.0 || >=16.0.0",
+    "npm": ">=7"
   },
   "husky": {
     "hooks": {

diff --git a/.eslintrc.js → packages/eslint-plugin/.eslintrc.js b/.eslintrc.js → packages/eslint-plugin/.eslintrc.js
@@ -2,7 +2,7 @@ module.exports = {
   extends: ["eslint:recommended"],
   plugins: ["jest", "node"],
   parserOptions: {
-    ecmaVersion: 2020,
+    ecmaVersion: 9,
   },
   env: {
     node: true,
@@ -15,7 +15,7 @@ module.exports = {
   },
   overrides: [
     {
-      files: ["packages/*/tests/**/*.test.js"],
+      files: ["*.test.js"],
       env: {
         "jest/globals": true,
       },

diff --git a/packages/eslint-plugin/lib/rules/no-restricted-attr-values.js b/packages/eslint-plugin/lib/rules/no-restricted-attr-values.js
@@ -66,11 +66,13 @@ module.exports = {
         node.attributes.forEach((attr) => {
           if (
             !attr.key ||
-            typeof attr.value?.value !== "string" ||
-            !attr.key?.value
+            !attr.key.value ||
+            !attr.value ||
+            typeof attr.value.value !== "string"
           ) {
             return;
           }
+
           const matched = checkers.find((checker) =>
             checker.test(attr.key.value, attr.value.value)
           );

diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -22,13 +22,14 @@
   },
   "scripts": {
     "test": "jest --coverage",
-    "check:ts": "tsc"
+    "check:ts": "tsc",
+    "lint": "eslint . --ext .js"
   },
   "bugs": {
     "url": "https://github.com/yeonjuan/html-eslint/issues"
   },
   "engines": {
-    "node": ">=8.10.0"
+    "node": "^12.22.0 || ^14.17.0 || >=16.0.0"
   },
   "keywords": [
     "eslint",

diff --git a/packages/website/package.json b/packages/website/package.json
@@ -6,7 +6,6 @@
     "dev": "next dev",
     "build": "next build && next export && touch ./out/.nojekyll && echo 'yeonjuan.github.io' > ./out/CNAME",
     "start": "next start",
-    "lint": "next lint",
     "ts": "tsc --noEmit"
   },
   "dependencies": {