-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "regex" option to id-naming-convention
#166
Conversation
not exactly the cleanest lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seleb Thanks for the contribution! The new options seems nice.
Could you update the docs? - docs/rules/id-naming-convention.md
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 47 47
Lines 1099 1102 +3
Branches 282 285 +3
=======================================
+ Hits 1080 1083 +3
Misses 19 19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seleb LGTM! Thanks !! Will be released this weekend
hey there! i ran into a case where
id-naming-convention
rule would be helpful, but the provided options are too strict to easily adopt (it's a large repo with multiple competing standards). this updates the rule to support a custom regex, which should hopefully make it flexible enough to cover any cases which deviate from the common standards