Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually export the new options #1825

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Actually export the new options #1825

merged 2 commits into from
Nov 28, 2023

Conversation

Benjamin-McRae-Tracsis
Copy link
Contributor

@Benjamin-McRae-Tracsis Benjamin-McRae-Tracsis commented Nov 20, 2023 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@Benjamin-McRae-Tracsis
Copy link
Contributor Author

Related to #1819

@Benjamin-McRae-Tracsis
Copy link
Contributor Author

Can I ask @parsonsmatt to review please?

@Benjamin-McRae-Tracsis
Copy link
Contributor Author

Oh, and please lmk when you push to Hackage, thank you!

@Benjamin-McRae-Tracsis
Copy link
Contributor Author

Hi @parsonsmatt, sorry to ping again, could I ask for a review?

parsonsmatt
parsonsmatt approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops! Should have caught that review earlier 😅

@parsonsmatt parsonsmatt merged commit b240282 into yesodweb:master Nov 28, 2023
9 of 14 checks passed
@parsonsmatt
Copy link
Contributor

Uploaded

@Benjamin-McRae-Tracsis
Copy link
Contributor Author

No worries, I appreciate the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjamin-McRae-Tracsis @parsonsmatt