Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop testing against stackage lts 11/12 #1837

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

dten
Copy link
Contributor

@dten dten commented Jul 8, 2024

since the requirement for attoparsec-aeson >= 2.1 was added this will no longer ever succeed

Before submitting your PR, check that you've:

After submitting your PR:

  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Since the MR that required attoparsec-aeson >= 2.1 #1818 then the older LTS that only have older aesons will never pass. This is confusing for any future MRs and seems like it should be removed it no one expects it to pass again.

Similarly there are two macos tests that fail as stack is not present, perhaps these should be removed until fixed also

since the requirement for attoparsec-aeson >= 2.1 was added this will no longer ever succeed
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit bcfcd94 into yesodweb:master Jul 11, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants