Implemenatation of chooseRadio function along with tests

[chrissound]

Before submitting your PR, check that you've:

• Bumped the version number
• Documented new APIs with Haddock markup
• Added @since declarations to the Haddocks for new, public APIs

After submitting your PR:

• Update the Changelog.md file with a link to your PR
• Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

I've been asked to upstream this work, so here it is! It's basically a helper function to make it easier to set radio form inputs.

[jezen]

This is an excellent addition the the library, though I think we ought to tidy up some minor details first.

[jezen]

I think typical radio input markup should look like this:

<input id="color-red" name="color" value="red">
<label for="color-red">Red</label>

i.e., the input should come before the label. Also, self-closing tags don't need a trailing slash.

[jezen]

I think v could be a better name. Perhaps labelText?

[jezen]

Since you're only using mres in one place, you may as well inline it.

Suggested change

	mres <- fmap rbdResponse getSIO
	res <-
	case mres of
	Nothing -> failure "chooseRadio: No response available"
	Just res -> return res
	res <- case rbdResponse <$> getSIO of
	Nothing -> failure "chooseRadio: No response available"
	Just res -> pure res

[chrissound]

I'm pretty sure this can't be inlined unless using LamdbdaCase >>= \case? Otherwise we need >>= (\v -> case v of ...) but I think that is less readable but happy to do that if preferred.

[jezen]

Similar deal here — this binding is only used once, so it may as well be inlined below.

[jezen]

Unless my eyes (and brain) are failing me, I think the parentheses are redundant here.

Suggested change

	let name = genericNameFromHTML (==) (v) body
	let name = genericNameFromHTML (==) labelText (simpleBody res)

[jezen]

The function application operators are redundant in both cases. Also, let's try to use slightly more descriptive names 🙂

Suggested change

	Right name' -> addPostParam name' $ v
	Left e -> failure $ e
	Right name' -> addPostParam name' labelText
	Left err -> failure err

[chrissound]

Thanks, will try sort this all out later today.

[jezen]

Closing this in favour of #1842.