Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds openapi annotation #92

Merged
merged 2 commits into from
Jul 19, 2024
Merged

adds openapi annotation #92

merged 2 commits into from
Jul 19, 2024

Conversation

invaliduser
Copy link
Contributor

No description provided.

@invaliduser invaliduser force-pushed the genopenapi branch 9 times, most recently from 7ba7633 to fede5ac Compare July 16, 2024 15:57
@invaliduser invaliduser marked this pull request as ready for review July 17, 2024 15:56
@invaliduser invaliduser requested a review from milt July 17, 2024 15:56
Copy link
Member

@milt milt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is the change to the way doc specs are decided (see my other note). Otherwise looks good.

@invaliduser invaliduser merged commit 0aaa60e into master Jul 19, 2024
13 checks passed

(def components
{:securitySchemes
{:bearerAuth {:type :http
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong but is this essentially referencing SQL LRS, and should that be in LRS lib?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its also not always true even in SQL LRS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants