fix(hl): use global namespace (closes #563) #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
changed the title
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #563, using namespaces introduced an unwanted ordering dependency on when the base color scheme was set
Based on playing around with the split pane and reading the code, I'm pretty sure the
input_nsnamespace highlights did nothing, so everything to do with them was just removed (the removed winhighlight comment is probably when they went dead)The
hint_nsnamespace is replaced with theAvantePopupHinthighlight group, which by default links toNormalFloatIn the same vein, I added the
AvanteInlineHintgroup to be able to style the hint that appears at the end of the line in visual mode, becausekeywordleads to quite obnoxious visuals by default imho.