Use nightly for Rustfmt (#2630)

* add rustfmt.toml, use nightly in CI, update contributing docs

* run `cargo +nightly fmt`

.github/workflows/fmt.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: stable
+          toolchain: nightly
           override: true
           profile: minimal
           components: rustfmt
@@ -25,4 +25,5 @@ jobs:
         uses: actions-rs/cargo@v1
         with:
           command: fmt
+          toolchain: nightly
           args: --all -- --check

CONTRIBUTING.md

@@ -73,7 +73,7 @@ The following command checks the code using Rustfmt and Clippy:
 cargo make lint
 ```
 
-To automatically fix formatting issues, run `cargo fmt` first.
+To automatically fix formatting issues, run `cargo +nightly fmt` first.
 
 ## Benchmarks
 
@@ -107,4 +107,4 @@ Below, you can find some useful guidance and best practices on how to write APIs
 The source code of our website ([https://yew.rs](https://yew.rs)) is in the [website directory](website).
 Most of the times, edits can be done in markdown.
 
-[website/README.md](website/README.md) has more detailed instructions.
+[website/README.md](website/README.md) has more detailed instructions.

Makefile.toml

@@ -30,6 +30,7 @@ run_task = { name = ["lint", "lint-release", "tests"], fork = true }
 [tasks.lint]
 category = "Checks"
 description = "Check formatting and run Clippy"
+toolchain = "nightly"
 run_task = { name = ["lint-flow"], fork = true }
 
 [tasks.tests]

examples/agents/src/lib.rs

@@ -1,6 +1,7 @@
 pub mod native_worker;
 
 use std::rc::Rc;
+
 use yew::{html, Component, Context, Html};
 use yew_agent::{Bridge, Bridged};
 

examples/agents/src/native_worker.rs

@@ -22,10 +22,10 @@ pub struct Worker {
 }
 
 impl yew_agent::Worker for Worker {
-    type Reach = Public<Self>;
-    type Message = Msg;
     type Input = Request;
+    type Message = Msg;
     type Output = Response;
+    type Reach = Public<Self>;
 
     fn create(link: WorkerLink<Self>) -> Self {
         let duration = 3;

examples/boids/src/boid.rs

@@ -1,9 +1,11 @@
+use std::iter;
+
+use rand::Rng;
+use yew::{html, Html};
+
 use crate::math::{self, Mean, Vector2D, WeightedMean};
 use crate::settings::Settings;
 use crate::simulation::SIZE;
-use rand::Rng;
-use std::iter;
-use yew::{html, Html};
 
 #[derive(Clone, Debug, PartialEq)]
 pub struct Boid {

examples/boids/src/main.rs

@@ -92,9 +92,10 @@ impl App {
     fn view_settings(&self, link: &Scope<Self>) -> Html {
         let Self { settings, .. } = self;
 
-        // This helper macro creates a callback which applies the new value to the current settings and sends `Msg::ChangeSettings`.
-        // Thanks to this, we don't need to have "ChangeBoids", "ChangeCohesion", etc. messages,
-        // but it comes at the cost of cloning the `Settings` struct each time.
+        // This helper macro creates a callback which applies the new value to the current settings
+        // and sends `Msg::ChangeSettings`. Thanks to this, we don't need to have
+        // "ChangeBoids", "ChangeCohesion", etc. messages, but it comes at the cost of
+        // cloning the `Settings` struct each time.
         macro_rules! settings_callback {
             ($link:expr, $settings:ident; $key:ident as $ty:ty) => {{
                 let settings = $settings.clone();

examples/boids/src/simulation.rs

@@ -1,8 +1,9 @@
+use gloo::timers::callback::Interval;
+use yew::{html, Component, Context, Html, Properties};
+
 use crate::boid::Boid;
 use crate::math::Vector2D;
 use crate::settings::Settings;
-use gloo::timers::callback::Interval;
-use yew::{html, Component, Context, Html, Properties};
 
 pub const SIZE: Vector2D = Vector2D::new(1600.0, 1000.0);
 

examples/boids/src/slider.rs

@@ -1,6 +1,8 @@
 use std::cell::Cell;
+
 use web_sys::HtmlInputElement;
-use yew::{events::InputEvent, html, Callback, Component, Context, Html, Properties, TargetCast};
+use yew::events::InputEvent;
+use yew::{html, Callback, Component, Context, Html, Properties, TargetCast};
 
 thread_local! {
     static SLIDER_ID: Cell<usize> = Cell::default();

examples/contexts/src/main.rs

@@ -3,13 +3,12 @@ mod producer;
 mod struct_component_subscriber;
 mod subscriber;
 
+use msg_ctx::MessageProvider;
 use producer::Producer;
 use struct_component_subscriber::StructComponentSubscriber;
 use subscriber::Subscriber;
 use yew::prelude::*;
 
-use msg_ctx::MessageProvider;
-
 #[function_component]
 pub fn App() -> Html {
     html! {

examples/contexts/src/struct_component_subscriber.rs

@@ -1,7 +1,7 @@
-use super::msg_ctx::MessageContext;
-
 use yew::prelude::*;
 
+use super::msg_ctx::MessageContext;
+
 pub enum Msg {
     MessageContextUpdated(MessageContext),
 }

examples/contexts/src/subscriber.rs

@@ -1,7 +1,7 @@
-use super::msg_ctx::MessageContext;
-
 use yew::prelude::*;
 
+use super::msg_ctx::MessageContext;
+
 #[function_component]
 pub fn Subscriber() -> Html {
     let msg_ctx = use_context::<MessageContext>().unwrap();

examples/dyn_create_destroy_apps/src/counter.rs

@@ -1,4 +1,5 @@
-use gloo::{console, timers::callback::Interval};
+use gloo::console;
+use gloo::timers::callback::Interval;
 use yew::prelude::*;
 
 pub struct CounterModel {
@@ -17,7 +18,6 @@ pub enum CounterMessage {
 
 impl Component for CounterModel {
     type Message = CounterMessage;
-
     type Properties = CounterProps;
 
     fn create(ctx: &Context<Self>) -> Self {

examples/dyn_create_destroy_apps/src/main.rs

@@ -16,7 +16,8 @@ pub enum Msg {
 }
 
 pub struct App {
-    apps: Slab<(Element, AppHandle<CounterModel>)>, // Contains the spawned apps and their parent div elements
+    apps: Slab<(Element, AppHandle<CounterModel>)>, /* Contains the spawned apps and their
+                                                     * parent div elements */
     apps_container_ref: NodeRef,
 }
 

examples/file_upload/src/main.rs

@@ -1,10 +1,10 @@
 use std::collections::HashMap;
 
-use web_sys::{Event, HtmlInputElement};
-use yew::{html, html::TargetCast, Component, Context, Html};
-
 use gloo_file::callbacks::FileReader;
 use gloo_file::File;
+use web_sys::{Event, HtmlInputElement};
+use yew::html::TargetCast;
+use yew::{html, Component, Context, Html};
 
 type Chunks = bool;
 

examples/function_memory_game/src/components/app.rs

@@ -1,12 +1,13 @@
+use std::cell::RefCell;
+use std::rc::Rc;
+
 use gloo::timers::callback::{Interval, Timeout};
-use std::{cell::RefCell, rc::Rc};
 use yew::prelude::*;
 use yew::{function_component, html};
 
-use crate::components::{
-    chessboard::Chessboard, game_status_board::GameStatusBoard, score_board::ScoreBoard,
-};
-
+use crate::components::chessboard::Chessboard;
+use crate::components::game_status_board::GameStatusBoard;
+use crate::components::score_board::ScoreBoard;
 use crate::constant::Status;
 use crate::state::{Action, State};
 

examples/function_memory_game/src/components/game_status_board.rs

@@ -1,7 +1,8 @@
-use crate::constant::Status;
 use yew::prelude::*;
 use yew::{function_component, html, Properties};
 
+use crate::constant::Status;
+
 #[derive(Properties, Clone, PartialEq)]
 pub struct Props {
     pub status: Status,

examples/function_memory_game/src/components/score_board.rs

@@ -1,8 +1,8 @@
 use yew::{function_component, html, Html, Properties};
 
-use crate::components::{
-    score_board_best_score::BestScore, score_board_logo::Logo, score_board_progress::GameProgress,
-};
+use crate::components::score_board_best_score::BestScore;
+use crate::components::score_board_logo::Logo;
+use crate::components::score_board_progress::GameProgress;
 
 #[derive(PartialEq, Properties, Clone)]
 pub struct Props {

examples/function_memory_game/src/state.rs

@@ -1,6 +1,7 @@
+use std::rc::Rc;
+
 use gloo::storage::{LocalStorage, Storage};
 use serde::{Deserialize, Serialize};
-use std::rc::Rc;
 use yew::prelude::*;
 
 use crate::constant::{CardName, Status, KEY_BEST_SCORE};

examples/function_router/src/app.rs

@@ -6,10 +6,12 @@ use yew_router::history::{AnyHistory, History, MemoryHistory};
 use yew_router::prelude::*;
 
 use crate::components::nav::Nav;
-use crate::pages::{
-    author::Author, author_list::AuthorList, home::Home, page_not_found::PageNotFound, post::Post,
-    post_list::PostList,
-};
+use crate::pages::author::Author;
+use crate::pages::author_list::AuthorList;
+use crate::pages::home::Home;
+use crate::pages::page_not_found::PageNotFound;
+use crate::pages::post::Post;
+use crate::pages::post_list::PostList;
 
 #[derive(Routable, PartialEq, Clone, Debug)]
 pub enum Route {

examples/function_router/src/components/author_card.rs

@@ -1,9 +1,12 @@
 use std::rc::Rc;
 
-use crate::{content::Author, generator::Generated, Route};
 use yew::prelude::*;
 use yew_router::prelude::*;
 
+use crate::content::Author;
+use crate::generator::Generated;
+use crate::Route;
+
 #[derive(Clone, Debug, PartialEq, Properties)]
 pub struct Props {
     pub seed: u32,

examples/function_router/src/components/pagination.rs

@@ -1,6 +1,6 @@
-use serde::Deserialize;
-use serde::Serialize;
 use std::ops::Range;
+
+use serde::{Deserialize, Serialize};
 use yew::prelude::*;
 use yew_router::prelude::*;
 

examples/function_router/src/components/post_card.rs

@@ -1,9 +1,12 @@
 use std::rc::Rc;
 
-use crate::{content::PostMeta, generator::Generated, Route};
 use yew::prelude::*;
 use yew_router::components::Link;
 
+use crate::content::PostMeta;
+use crate::generator::Generated;
+use crate::Route;
+
 #[derive(Clone, Debug, PartialEq, Properties)]
 pub struct Props {
     pub seed: u32,

examples/function_router/src/generator.rs

@@ -1,6 +1,9 @@
 use lazy_static::lazy_static;
 use lipsum::MarkovChain;
-use rand::{distributions::Bernoulli, rngs::StdRng, seq::IteratorRandom, Rng, SeedableRng};
+use rand::distributions::Bernoulli;
+use rand::rngs::StdRng;
+use rand::seq::IteratorRandom;
+use rand::{Rng, SeedableRng};
 
 const KEYWORDS: &str = include_str!("../data/keywords.txt");
 const SYLLABLES: &str = include_str!("../data/syllables.txt");

examples/function_router/src/pages/author.rs

@@ -1,7 +1,9 @@
-use crate::components::author_card::AuthorState;
-use crate::{content, generator::Generated};
 use yew::prelude::*;
 
+use crate::components::author_card::AuthorState;
+use crate::content;
+use crate::generator::Generated;
+
 #[derive(Clone, Debug, Eq, PartialEq, Properties)]
 pub struct Props {
     pub seed: u32,

examples/function_router/src/pages/author_list.rs

@@ -1,7 +1,9 @@
-use crate::components::{author_card::AuthorCard, progress_delay::ProgressDelay};
 use rand::{distributions, Rng};
 use yew::prelude::*;
 
+use crate::components::author_card::AuthorCard;
+use crate::components::progress_delay::ProgressDelay;
+
 /// Amount of milliseconds to wait before showing the next set of authors.
 const CAROUSEL_DELAY_MS: u32 = 15000;
 

examples/function_router/src/pages/post.rs

@@ -1,10 +1,12 @@
 use std::rc::Rc;
 
-use crate::{content, generator::Generated, Route};
 use content::PostPart;
 use yew::prelude::*;
 use yew_router::prelude::*;
 
+use crate::generator::Generated;
+use crate::{content, Route};
+
 #[derive(Clone, Debug, Eq, PartialEq, Properties)]
 pub struct Props {
     pub seed: u32,

examples/function_router/src/pages/post_list.rs

@@ -1,9 +1,10 @@
-use crate::components::pagination::PageQuery;
-use crate::components::{pagination::Pagination, post_card::PostCard};
-use crate::Route;
 use yew::prelude::*;
 use yew_router::prelude::*;
 
+use crate::components::pagination::{PageQuery, Pagination};
+use crate::components::post_card::PostCard;
+use crate::Route;
+
 const ITEMS_PER_PAGE: u32 = 10;
 const TOTAL_PAGES: u32 = u32::MAX / ITEMS_PER_PAGE;
 

examples/function_todomvc/src/components/entry.rs

@@ -1,9 +1,10 @@
-use crate::hooks::use_bool_toggle::use_bool_toggle;
-use crate::state::Entry as Item;
 use web_sys::{HtmlInputElement, MouseEvent};
 use yew::events::{Event, FocusEvent, KeyboardEvent};
 use yew::prelude::*;
 
+use crate::hooks::use_bool_toggle::use_bool_toggle;
+use crate::state::Entry as Item;
+
 #[derive(PartialEq, Properties, Clone)]
 pub struct EntryProps {
     pub entry: Item,

examples/function_todomvc/src/components/filter.rs

@@ -1,6 +1,7 @@
-use crate::state::Filter as FilterEnum;
 use yew::prelude::*;
 
+use crate::state::Filter as FilterEnum;
+
 #[derive(PartialEq, Properties)]
 pub struct FilterProps {
     pub filter: FilterEnum,

examples/function_todomvc/src/hooks/use_bool_toggle.rs

@@ -1,5 +1,6 @@
 use std::ops::Deref;
 use std::rc::Rc;
+
 use yew::prelude::*;
 
 #[derive(Clone)]

examples/function_todomvc/src/main.rs

@@ -7,10 +7,10 @@ mod components;
 mod hooks;
 mod state;
 
-use components::{
-    entry::Entry as EntryItem, filter::Filter as FilterItem, header_input::HeaderInput,
-    info_footer::InfoFooter,
-};
+use components::entry::Entry as EntryItem;
+use components::filter::Filter as FilterItem;
+use components::header_input::HeaderInput;
+use components::info_footer::InfoFooter;
 
 const KEY: &str = "yew.functiontodomvc.self";