Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render phase can be interrupted #1326

Closed
jstarry opened this issue Jun 18, 2020 · 0 comments · Fixed by #1360
Closed

Render phase can be interrupted #1326

jstarry opened this issue Jun 18, 2020 · 0 comments · Fixed by #1360

Comments

@jstarry
Copy link
Member

jstarry commented Jun 18, 2020

Problem

In #1309, the scheduler was modified to group render tasks together to improve performance. However, grouped render tasks can get disrupted if any of the associated components has a rendered() lifecycle method that pushes an update task into the scheduler (self.link.send_message(..)).

Proposed Changes

Split the scheduler's "render" task queue into "render" and "rendered" so that renders won't be disrupted and can run in batches properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant