Split update and render operations into seprate tasks #1309
Conversation
|
@siku2 any idea why the comment failed on the benchmark script? |
No, not really... Could you try re-running the workflow? |
|
In my fork the comment is working (siku2#5) so I hope this was just a fluke... yew/.github/workflows/benchmark.yaml Line 42 in a6295bf It should be the following now: { git = \"https://github.com/jstarry/yew\", branch = \"split-render\" }.
I honestly wasn't expecting you to change that line in the near future. I guess we need to come up with a better solution than a simple search and replace after all... |
No worries, I kept it in the back of my mind too 😉 I just updated it here: yewstack/js-framework-benchmark@7bb7b65 |
|
@siku2 I think it's because of this:
|
|
Maybe it can be triggered by adding a label to the PR? |
|
Here's an issue: #1311 |
* Split update and render operations into seprate tasks * Fix functional components * Rename internal functional component terms
Description
DOM updates are much more efficient when batched together but Yew does not do so when rendering components. This change moves the DOM updates to the "render" task (formerly "rendered"). This allows the scheduler to render to the DOM in quick succession since the virtual dom has already been created.
Related to #1153
Checklist:
./ci/run_stable_checks.sh