Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add msg queuing for all messages for public agents #1007

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Add msg queuing for all messages for public agents #1007

merged 3 commits into from
Mar 8, 2020

Conversation

TheNeikos
Copy link
Contributor

Fixes #944

@TheNeikos TheNeikos force-pushed the fix/add_connecting_message_to_public_agents branch from 48e866a to 90aa108 Compare March 8, 2020 09:55
@jstarry
Copy link
Member

jstarry commented Mar 8, 2020 •
edited
Loading

Great, this is exactly what I had in mind. Do you mind making a few more tweaks:

  1. Send Disconnected and Destroy through your new send_message method
  2. Remove the TODO (Send the Connected message when the public worker is loaded #944) comment

@TheNeikos
Send Disconnected and Destroy correctly
142c623 
They now use the `send_message` so that they also
get queued in case the worker is not ready yet
@TheNeikos
Remove todo about connected message
5b755d0
@TheNeikos
Copy link
Contributor Author

@jstarry Done!

@jstarry
Copy link
Member

jstarry commented Mar 8, 2020

Thanks!

@jstarry jstarry merged commit d700525 into yewstack:master Mar 8, 2020
@TheNeikos TheNeikos deleted the fix/add_connecting_message_to_public_agents branch March 8, 2020 18:51
nicklaswj pushed a commit to nicklaswj/yew that referenced this pull request Mar 13, 2020
@TheNeikos @nicklaswj
Add msg queuing for all messages for public agents (yewstack#1007)
73c43e6 
* Add msg queuing for all messages for public agents

Fixes yewstack#944

* Send Disconnected and Destroy correctly

They now use the `send_message` so that they also
get queued in case the worker is not ready yet

* Remove todo about connected message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send the Connected message when the public worker is loaded
2 participants
@TheNeikos @jstarry