Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counter examples #1184

Merged
merged 1 commit into from
May 4, 2020
Merged

Conversation

qwolphin
Copy link
Contributor

@qwolphin qwolphin commented May 4, 2020

I've spent a few minutes trying to figure out why my code in Bulk msg handling is doing nothing. Looks like the examples were updated to use batch_callback instead of manual Bulk handling in f48bc90. I've just removed the confusing code.

grep found no other Bulk in examples, so (probably) there are no other similar mistakes

@jstarry jstarry merged commit 1025000 into yewstack:master May 4, 2020
@jstarry
Copy link
Member

jstarry commented May 4, 2020

Sorry about that confusion, thanks for cleaning this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants